Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rockspec for 3.1.5 #17

Merged
merged 1 commit into from
Oct 17, 2015
Merged

Add rockspec for 3.1.5 #17

merged 1 commit into from
Oct 17, 2015

Conversation

Alloyed
Copy link
Contributor

@Alloyed Alloyed commented Oct 16, 2015

Adding so bump.lua can be managed with LÖVERocks.
To avoid PR spam, I'll just mention that I have similar rockspecs in for tween.lua, gamera, and anim8 in this test repo
If possible, can you also upload the rockspecs to luarocks.org so it can be used without a custom repository? Thank you.

kikito added a commit that referenced this pull request Oct 17, 2015
@kikito kikito merged commit c5db031 into kikito:master Oct 17, 2015
@kikito
Copy link
Owner

kikito commented Oct 17, 2015

Hey, thanks a lot for this!

I have merged this and uploaded it to luarocks.

I will add the rockspecs for tween, gamera and anim8 now. Thanks again for writing them!

@kikito
Copy link
Owner

kikito commented Oct 17, 2015

I have had second thoughts about this.

I have uploaded bump and tween rockspecs (again, thanks!) but I have second thoughts about gamera and anim8.

The difference between bump.lua/tween.lua and gamera/anim8 is that the first two work well in Lua by itself, but the later two only work inside LÖVE. I am not sure I want to "pollute the official luarocks folder" which something which does not work in all versions of Lua.

I would not object so heavily if there was some kind of namespace for the rocks which only work with LÖVE. I am thinking about naming the rockspecs something like love-gamera and love-anim8 instead, so that it is clear that these only work with LÖVE. What do you think?

@Alloyed
Copy link
Contributor Author

Alloyed commented Oct 17, 2015

That seems fine to me for clarity reasons, but I am a little worried by the fact that the name of the luarocks package and the name of the lua module would be different in that case.

Where luarocks will tell you ahead of time if you try to upload/install a package with the same name as another package, if "my-great-package.rockspec" and "your-great-package.rockspec" both install a module called "great", the only way to tell there's a conflict is to actually try to require("great") in application code and get the wrong one.

So I'd be more comfortable if you also changed the module name in the build table if you go down that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants