Fix seekFrameIndex #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It erroneously returned an index one too early if the passed in `timer` happened to exactly match one of the intervals — a situation easily created by `gotoFrame`. I ran into this when using `gotoFrame` in `onLoop` for an animation with a "lead-in" part; every time it looped, I'd see a flicker for exactly one frame where the bogus index had slipped in.
|
Hey, thanks a lot! I've been wanting to fix this for a while now, but couldn't find the time to debug it. I really appreciate that you took the time to fix the tests too. |
This was referenced Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It erroneously returned an index one too early if the passed in
timerhappened to exactly match one of the intervals — a situation easily created bygotoFrame.I ran into this when using
gotoFrameinonLoopfor an animation with a "lead-in" part; every time it looped, I'd see a flicker for exactly one frame where the bogus index had slipped in.