Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude specs from coverage report #22

Merged
merged 1 commit into from
May 14, 2017
Merged

Exclude specs from coverage report #22

merged 1 commit into from
May 14, 2017

Conversation

jaythomas
Copy link
Contributor

I noticed here that the spec file was being included in the coverage report, which taints the overall coverage percentage of the report. The coverage of spec files is useless information because it's always going to be 100% since the test runner will always run everything in it.

@coveralls
Copy link

coveralls commented Mar 4, 2017

Coverage Status

Coverage increased (+1.1%) to 99.412% when pulling db87248 on jaythomas:coverage-fix into 539cc26 on kikito:master.

@kikito kikito merged commit ff8c9cc into kikito:master May 14, 2017
@kikito
Copy link
Owner

kikito commented May 14, 2017

Thanks for this, and sorry it took me so much time to accept it. It went under my radar

@jaythomas jaythomas deleted the coverage-fix branch May 15, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants