Fix Path.Constructor createPath arguments if { insert: true }

khrome · Oct 20, 2022 · 8be1e34 · 8be1e34
1 parent b85d4c5
commit 8be1e34
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/path/Path.Constructors.js b/src/path/Path.Constructors.js
@@ -22,7 +22,10 @@ Path.inject({ statics: new function() {
 
  function createPath(segments, closed, args) {
  var props = Base.getNamed(args),
- path = new Path(props && props.insert == false && Item.NO_INSERT);
+ path = new Path(props && (props.insert == true
+ ? { insert: true }
+ : props.insert == false && Item.NO_INSERT
+ ));
  path._add(segments);
  // No need to use setter for _closed since _add() called _changed().
  path._closed = closed;

diff --git a/test/tests/Path_Constructors.js b/test/tests/Path_Constructors.js
@@ -35,6 +35,13 @@ test('new Path.Circle({ center: [100, 100], radius: 50 })', function() {
  equals(path.segments.toString(), '{ point: { x: 50, y: 100 }, handleIn: { x: 0, y: 27.61424 }, handleOut: { x: 0, y: -27.61424 } },{ point: { x: 100, y: 50 }, handleIn: { x: -27.61424, y: 0 }, handleOut: { x: 27.61424, y: 0 } },{ point: { x: 150, y: 100 }, handleIn: { x: 0, y: -27.61424 }, handleOut: { x: 0, y: 27.61424 } },{ point: { x: 100, y: 150 }, handleIn: { x: 27.61424, y: 0 }, handleOut: { x: -27.61424, y: 0 } }');
 });
 
+test('new Path.Circle({ center: [100, 100], radius: 50, insert: true })', function() {
+ paper.settings.insertItems = false;
+ var path = new Path.Circle({ center: [100, 100], radius: 50, insert: true });
+ equals(path.isInserted(), true);
+ paper.settings.insertItems = true;
+});
+
 test('new Path.Ellipse(rect)', function() {
  var rect = new Rectangle([500, 500], [1000, 750]);
  var path = new Path.Ellipse(rect);