Allow just one worker to be the background schedule leader #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iple schedulers - Reduce the load on the DB and risk of issues on the service side by limiting the execution environment to one elected leader at a given time. This one is responsible for manging all of the execution of the jobs, though all workers are capaable of adding and removing jobs
…f automation not added successfully
sabaimran
commented
Jun 28, 2024
sabaimran
commented
Jun 28, 2024
|
|
||
|
|
||
| @schedule.repeat(schedule.every(17).minutes) | ||
| def wakeup_scheduler(): |
There was a problem hiding this comment.
Disclaimer.
I'm not actually sure if this is required, but I think the leader worker won't automatically be aware of new jobs being added to the store unless wakeup is explicitly called. There are some background operations that will trigger wakeup, but I don't think it's dependable, so this may be a good workaround.
stevennt
added a commit
to stevennt/myai.abn.khoj.old.abandon
that referenced
this pull request
Jun 28, 2024
Allow just one worker to be the background schedule leader (khoj-ai#836)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid additional load on the DB and server in production, elect only one worker to be the background schedule leader to run and execute automations. The other workers are started in a
paused state, allowing them to delete and add new jobs, but not running jobs.