Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

/close does not close the config portal #16

Closed
marcelstoer opened this issue Sep 24, 2020 · 6 comments
Closed

/close does not close the config portal #16

marcelstoer opened this issue Sep 24, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@marcelstoer
Copy link
Contributor

marcelstoer commented Sep 24, 2020

I'm using Async_ConfigOnSwitch (1.1.2) unchanged on ESP32.

When I click "Exit Portal" (i.e. request /close) the WiFi Manager remains in config mode until timeout is reached. This is unexpected to me. I expected the config portal to close and for the WiFi Manager to go back to station mode.

In order to exit the config portal I have to hit "Configuration" and then "Save" without entering any values.

Does this work as designed?

@khoih-prog
Copy link
Owner

@marcelstoer

Can you un-comment this Line 1715 from

//stopConfigPortal = true; //signal ready to shutdown config portal		//KH crash if use this ???

to

stopConfigPortal = true; //signal ready to shutdown config portal		//KH crash if use this ???

to see if that is what you expect.

Possibly I forgot to un-comment after tested last time.

@marcelstoer
Copy link
Contributor Author

Indeed, that's the behavior I would expect. Thanks! In fact, on iOS the config portal window/dialog closes so quickly now that you don't even get to see the /close response "page". Not that I would care about it anyway 😄 Important is that the portal is shut down and that works nicely now.

@khoih-prog
Copy link
Owner

That's good. Will update in next release.

@khoih-prog khoih-prog added the bug Something isn't working label Sep 25, 2020
@marcelstoer
Copy link
Contributor Author

Can I ask you to keep issues open until the respective fix has landed on master? That would allow us to be notified by GitHub when we can update our dependencies.

khoih-prog added a commit that referenced this issue Sep 28, 2020
@khoih-prog
Copy link
Owner

Master updated.

khoih-prog added a commit to khoih-prog/ESP_WiFiManager that referenced this issue Oct 15, 2020
### Releases v1.2.0

1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](#38) and [`Support building in PlatformIO PR`](#20). SSee [**HOWTO Fix `Multiple Definitions` Linker Error**](https://github.com/khoih-prog/ESP_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error)
2. Fix bug [/close does not close the config portal](khoih-prog/ESPAsync_WiFiManager#16).
khoih-prog added a commit to khoih-prog/ESP_WiFiManager that referenced this issue Oct 15, 2020
### Releases v1.2.0

1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](#38) and [`Support building in PlatformIO PR`](#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESP_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error)
2. Fix bug [/close does not close the config portal](khoih-prog/ESPAsync_WiFiManager#16).
khoih-prog added a commit that referenced this issue Oct 16, 2020
### Releases v1.2.0

1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](khoih-prog/ESP_WiFiManager#38) and [`Support building in PlatformIO PR`](khoih-prog/ESP_WiFiManager#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESPAsync_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error)
2. Fix bug [/close does not close the config portal](#16).
khoih-prog added a commit that referenced this issue Oct 16, 2020
### Releases v1.2.0

1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](khoih-prog/ESP_WiFiManager#38) and [`Support building in PlatformIO PR`](khoih-prog/ESP_WiFiManager#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESPAsync_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error)
2. Fix bug [/close does not close the config portal](#16).
@khoih-prog
Copy link
Owner

See ESP_WiFiManager v1.2.0 and Contributions-and-Thanks

Releases v1.2.0

  1. Restore cpp code besides Impl.h code to use in case of multiple definition linker error. See Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h and Support building in PlatformIO PR. Also have a look at HOWTO Fix Multiple Definitions Linker Error
  2. Fix bug /close does not close the config portal.

khoih-prog added a commit that referenced this issue Oct 16, 2020
### Releases v1.2.0

1. Restore cpp code besides Impl.h code to use in case of `multiple definition` linker error. See [`Change Implementation to seperate *.h and *.cpp file instead of *.h and *-Impl.h`](khoih-prog/ESP_WiFiManager#38) and [`Support building in PlatformIO PR`](khoih-prog/ESP_WiFiManager#20). Also have a look at [**HOWTO Fix Multiple Definitions Linker Error**](https://github.com/khoih-prog/ESPAsync_WiFiManager#HOWTO-Fix-Multiple-Definitions-Linker-Error)
2. Fix bug [/close does not close the config portal](#16).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants