Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add support for getting users from hidden replies page #305

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

INSANEMODE
Copy link
Contributor

Support checking ModeratedTimeline to gather users from hidden replies under a tweet.

Should work on pages like this: https://x.com//status//hidden


This is a long-lived branch, intended to aggregate all changes planned for version VERSION.

Pull requests should be made against this branch. Merges to this branch should be done via a merge commit. When ready, this branch should be merged to main via a squash commit.

Changelog

Summary
	1. document grouping follow 'SemVer2.0' protocol
	2. use 'PATCH' as a minimum granularity
	3. use concise descriptions
	4. type: feat \ fix \ update \ perf \ remove \ docs \ chore
	5. version timestamp follow the yyyy.MM.dd format

Deployment Checklist

  1. merge all pull requests to llb
  2. ensure src/manifest.ts and package.json have the correct version number
  3. use makefile to generate zips (make chrome, make firefox)
    • chrome should be tested with npm run build
    • test firefox locally using zip
  4. merge llb to main
  5. upload zips from 3 to chrome webstore and firefox addons

cooljeanius
cooljeanius previously approved these changes Jul 6, 2024
Copy link
Collaborator

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming it works

Copy link
Collaborator

@rougetimelord rougetimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rougetimelord rougetimelord changed the base branch from main to 0.4.3 July 15, 2024 10:51
@cooljeanius
Copy link
Collaborator

There's now a merge conflict that needs to be resolved...

@INSANEMODE
Copy link
Contributor Author

Looks like am easy one to resolve. Just need to update the regex, and readd ModeratedTimeline to it.

I won't be at a computer to do this until after work, or about 7 hours, but I can resolve it if it still needs it by then.

@INSANEMODE
Copy link
Contributor Author

OK, I took the current regex and re-added ModeratedTimeline to resolve the conflict.

@cooljeanius cooljeanius merged commit 3a68e3a into kheina-com:0.4.3 Jul 16, 2024
@rougetimelord rougetimelord mentioned this pull request Jul 17, 2024
7 tasks
kheina added a commit that referenced this pull request Aug 10, 2024
* [chore] bump version string

* [Feat] get users from tweet like pages (#286)

* [fix] remove duplicate regex part

* [feat] add scraping from the tweet engagements likes tab

* [chore] bump version string

* [fix] ignore empty user_result objects

* use exponential backoff when messaging background script (#285)

* use exponential backoff when messaging bgscript in case it's down

* break backoff into standalone func

---------

Co-authored-by: dani <[email protected]>

* [feat] add support for getting users from hidden replies page (#305)

* add support for checking hidden replies

* [chore] bump version string

---------

Co-authored-by: Rouge <[email protected]>

* Rewrite EscapeHTML func to be safer (#295)

* [fix] Rewrite EscapeHTML func to be safer

* [fix] explicitly replace <, >, and &

H/T @bkh555 for posting OSWAP guidelines <3

* [fix] make ampersand regex global, make sure not to catch ampersands in entities

* [fix] remove explicit <>& replacements

* Update release.yml

Bump browser-actions/release-firefox-addon from 0.1.3 to 0.1.4
Bumps [browser-actions/release-firefox-addon](https://github.com/browser-actions/release-firefox-addon) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/browser-actions/release-firefox-addon/releases)
- [Changelog](https://github.com/browser-actions/release-firefox-addon/blob/master/CHANGELOG.md)
- [Commits](browser-actions/release-firefox-addon@v0.1.3...v0.1.4)

* Add privacy policy within repo (#296)

* [chore] add privacy policy within repo

Yippie I get to use my rules lawyering brain for good instead of scaring the hoes :))))

* [fix] typos

lol oops

Co-authored-by: Eric Gallager <[email protected]>

---------

Co-authored-by: Eric Gallager <[email protected]>

* Make tabs more granular, reduce build size (#287)

* update tabs and cleanup some build files for a smaller zip

* [fix] Migrate users to new tabs

---------

Co-authored-by: dani <[email protected]>
Co-authored-by: Rouge <[email protected]>

* edit the privacy update a little bit

* spelling

---------

Co-authored-by: dani <[email protected]>
Co-authored-by: INSANEMODE <[email protected]>
Co-authored-by: Eric Gallager <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants