Create a more granular version of CODEOWNERS #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help keep review requests be more precisely targeted to relevant reviewers
cooljeanius
requested review from
kheina,
jaredcat,
MrAwesome and
rougetimelord
as code owners
jaredkotoff is now @jaredcat
|
btw this removes @MrAwesome from the file, since I didn't see him in the history in any of the files I checked... I'm assuming he'd probably be somewhere in some of the ones I skipped in |
jaredcat
previously approved these changes
Jun 16, 2024
|
Looks like it's still requiring an approval from @kheina, @MrAwesome, or @rougetimelord? |
@shinmai, @Suyooo, @MeguminSama, @MaxIsJoe, or @Psotle, do any of you want to be added for the files you've edited? |
|
what little I contributed I did in lieu of someone with time & energy doing properly what I hacked together, which it seems has happened, so I'm content :) |
|
My contributions have been pretty minor. Happy either way. |
Idk how vite works!! I should be kept away from tinkering with it :)
rougetimelord
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help keep review requests be more precisely targeted to relevant reviewers.
I made the decisions for who to assign to which files based on git history and blame, as well as in my personal case, just selecting files I'd be comfortable editing. Note that I didn't dig in too deep to the history in
src/*, so it's possible there could be additional changes to make there. Also, I had previously added more names than this, but removed people who never responded to my invitations to collaborate on my fork.