Escapable blocks of text #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g different escape sequences together. Make sure escape sequences are in the final prompt. Organize test file
|
Nice! Thanks for the contribution. Do you mind adding a test with a multiline string? Otherwise should be good |
|
Good idea. I added a test for multiline string. |
kharvd
reviewed
Jun 27, 2024
tests/test_term_utils.py
Outdated
Comment on lines
59
to
61
| "this is a prompt \n--bar=1.0 \n--baz=2.0 \n {start}another line \nmy final line{end}", | ||
| "this is a prompt \n \n \n {start}another line \nmy final line{end}", | ||
| {'bar': '1.0', 'baz': '2.0'}, |
There was a problem hiding this comment.
does it make sense to test the case when the arguments are within the escaped block as well?
There was a problem hiding this comment.
added "--foo=3.0" in a part of the multi-line text, to ensure it is not parsed.
kharvd
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow escapable blocks of text when wrapped in triple backticks or quotes. Fixes #52