Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customing log filename with date and time #44

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

ChrisJefferson
Copy link
Contributor

I find this useful myself, so I thought I'd make a PR.

This runs the logfile name through strftime, making it easy to make logs based on the current time + date. For example, I use:

logs/gpt-cli/%Y-%m-%d_%H-%M-%S.log

The only problem I see with this is it might break logging for people who used % as part of the filename (as anything starting % will get interpreted by strftime).

Copy link
Owner

@kharvd kharvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kharvd kharvd merged commit ee5fad7 into kharvd:main Jul 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants