Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building on modern MSYS2 #13

Open
wants to merge 13 commits into
base: gnustep_testplant_branch
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Detect presence of NSCellUndoManager
  • Loading branch information
qmfrederik committed Apr 30, 2024
commit 0136c86f7fbd8319bf68bd944ab8a4a42c5a8147
9 changes: 8 additions & 1 deletion Source/NSCell.m
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@
#import "GSGuiPrivate.h"
#import "AppKit/NSTextFieldCell.h"
#import "AppKit/NSSearchFieldCell.h"

// Use NSAppleEventDescriptor as a proxy for detecting the Eggplant fork of libs-base
#if !__has_include("Foundation/NSAppleEventDescriptor.h")
#define HAVE_NSCellUndoManager
#endif

static Class colorClass;
static Class cellClass;
static Class fontClass;
Expand Down Expand Up @@ -2351,6 +2357,7 @@ incorrectly be reduced to zero (since the text object has no contents at
_cell.in_editing = YES;

// TESTPLANT-MAL-12282916: Paul Landers added this code...need to keep it...
#ifdef HAVE_NSCellUndoManager
if ([textObject isKindOfClass:[NSTextView class]])
{
NSCellUndoManager * undoManager = [[NSCellUndoManager alloc] init];
Expand All @@ -2359,7 +2366,7 @@ incorrectly be reduced to zero (since the text object has no contents at
[undoManager release];
[(NSTextView *)textObject setAllowsUndo:YES];
}

#endif

#if 1
// Testplant-MAL-2015-06-20: merging removal causes focus ring issues...
Expand Down