Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEYCLOAK-18699 Brand logo is not found for product admin console #8255

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented Jul 9, 2021

JIRA: KEYCLOAK-18699

@Pepo48 @vmuzikar @ssilvert Could you please take a look at it? Thank you very much.

@hmlnarik hmlnarik requested a review from ssilvert July 14, 2021 10:46
@hmlnarik hmlnarik added this to the 14.0.1 milestone Jul 14, 2021
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabartos Thanks for the fix! Changes as such LGTM, but please bear in mind I didn't test them as I'm unable to build RH-SSO dist (as we discussed privately).

Copy link
Contributor

@ssilvert ssilvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssilvert ssilvert merged commit 8c49478 into keycloak:master Jul 19, 2021
@Pepo48
Copy link
Contributor

Pepo48 commented Jul 19, 2021

LGTM as well. Thanks @mabartos

bohmber pushed a commit to bohmber/keycloak that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants