Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Keycloak server URL for common resources (#30823) #30827

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jonkoops
Copy link
Contributor

Closes #30541

Signed-off-by: Jon Koops [email protected]
(cherry picked from commit cd0dbdf)

@jonkoops jonkoops requested a review from a team as a code owner June 26, 2024 15:07
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backport differs from the original patch as the structure code was changed significantly between v22 and v24.

@vmuzikar vmuzikar self-assigned this Jun 26, 2024
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on offline testing with @jonkoops.

@vmuzikar vmuzikar enabled auto-merge (squash) June 26, 2024 15:47
@vmuzikar vmuzikar merged commit d618a27 into keycloak:release/22.0 Jun 26, 2024
62 checks passed
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflow

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az773-334', ip: '10.1.0.123', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1022-azure', java.version: '17.0.11'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@jonkoops jonkoops deleted the backport-30823-22.0 branch June 26, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants