Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to no override flow when missing in client override #30766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lexcao
Copy link
Contributor

@lexcao lexcao commented Jun 25, 2024

Closes #30765

@ahus1
Copy link
Contributor

ahus1 commented Jun 26, 2024

@graziang - this PR is related to an issue you commented on, therefore pinging you here.

@mposolda mposolda self-assigned this Jun 26, 2024
Copy link
Contributor

@graziang graziang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexcao Thanks! LGTM. @ahus1 let's wait for @mposolda's review before merging

Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexcao @graziang Thanks for the fix and review! Added two other minor inline comments regarding logging message. IMO this can be merged once this is addressed.

@lexcao lexcao force-pushed the feat/fallback-no-override-flow branch from 2cf1e37 to 96b8bbc Compare July 12, 2024 14:49
@lexcao
Copy link
Contributor Author

lexcao commented Jul 12, 2024

Hi @mposolda
Thanks, my mistake, just updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fallback to the no override flow when the flow is missing in client override
4 participants