-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch login theme to keycloak v2 #30319
base: main
Are you sure you want to change the base?
Switch login theme to keycloak v2 #30319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
f27f246
to
082f0d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.OidcClaimToUserSessionNoteMapperTest#claimIsPropagatedOnAllLoginsWhenNameMatchesAndSyncModeIsForce
org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
173151e
to
6bee030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.OidcClaimToUserSessionNoteMapperTest#claimIsPropagatedOnFirstLoginOnlyWhenNameMatchesAndSyncModeIsImport
org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
9e7a645
to
2d55a1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.OidcClaimToUserSessionNoteMapperTest#claimIsPropagatedOnAllLoginsWhenNameMatchesAndSyncModeIsForce
org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
2d55a1f
to
718c817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
|
718c817
to
dea8f2c
Compare
This fixes the findings from #30319. The tests are not updated and are run on legacy keycloak theme. The new login theme is kept disabled, since otherwise it would be treated as default and used by tests which is said to be unacceptable due to test duration. Fixes: #29009 Signed-off-by: Hynek Mlnarik <[email protected]>
f989f43
to
fe5fa8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
org.keycloak.testsuite.account.AccountRestServiceTest#listApplicationsWithoutPermissionKeycloak CI - Java Distribution IT (windows-latest - temurin - 17)
|
Fixes: keycloak#29009 Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
alert-error -> pf-v5-c-alert XPath for profile inputs Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
The `base` theme can be used for SSSD tests. Several tests from the FIPS testsuite look for a feedback message which in turn is only available in the `keycloak` theme. Thus the FIPS testsuite currently defers to `keycloak` theme. Ideally, it would also use the `base` theme only. Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
Signed-off-by: Hynek Mlnarik <[email protected]>
fe5fa8d
to
c911eaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.OidcClaimToUserSessionNoteMapperTest#claimIsNotPropagatedWhenNameDoesNotMatchKeycloak CI - Store IT (pus-rc)
org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant1SamlTest
org.keycloak.testsuite.broker.OidcClaimToUserSessionNoteMapperTest#claimIsPropagatedOnFirstLoginOnlyWhenNameMatchesAndSyncModeIsImportKeycloak CI - Store IT (pus-ec)
|
This PR upgrades the keycloak.v2 login theme from experimental to default and fixes few remaining bugs and testsuites.
EDIT: The themes were fixed in #30656
Notes:
Fixes: #29009