This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ATM, the KnpMenu doesn't work.
Note : Knp Breadcrumb neither..
Result with the
knp_menu.md
example:header
doesn't display ❌header
have a bad style ❌I've updated the template to match the AdminLTE 3 menu.
Template update (nothing too fancy):
header item type
classitem.label
to header item display<a>
for item with child (remove 'route' required param)KnpMenuBuilderSubscriber.php
for header items type fromheader
tonav-header
->setAttribute('class', 'header');
❌->setAttribute('class', 'nav-header');
✔️DOC update:
Header item
classroute
param for item with childResult after FIX:
Types of changes
Checklist