Improve IE11 compatibility

[tbordinat]

Description

On IE11, I have a really annoying menu transition on each page I load.
This little trick resolves the problem without changing anything at first sight.

Solution found here : https://adminlte.io/themes/AdminLTE/index2.html

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I updated the documentation (see here)
• I agree that this code is used in AdminLTEBundle and will be published under the MIT license

[kevinpapst]

Thanks! Can you describe what kind of transition you are seeing?
Can you probably add a short screen record / animated gif of the problem?

Actually it is 2020 and time to stop patching something that works, just for IE users ... 😁 👿
I'd like to understand that class and which consequences it will have for all other browsers.

[tbordinat]

Thanks! Can you describe what kind of transition you are seeing?
Can you probably add a short screen record / animated gif of the problem?

Actually it is 2020 and time to stop patching something that works, just for IE users ... 😁 👿
I'd like to understand that class and which consequences it will have for all other browsers.

Sure, here we go :

I don't have this problem on Chrome, obviously :D

And with this patch :

I can't upgrade 80k computers right now :-( haha

I'll investigate more on this class, and the other option I have is to add maybe a new block, as {% block body_class %}{% endblock %}, would it be preferable ?

[kevinpapst]

I think you could add the class to the bundle config key skin.
Eg. like here: https://github.com/kevinpapst/AdminLTEBundle/blob/master/Resources/docs/bundle_options.md

skin: 'skin-blue hold-transition'

I believe this config key is not used anywhere else.

But if that is a general problem for all IE11 users, I'd probably fix it in the bundle.

I don't have windows here, so I can't test it... Does the class affect the other browsers somehow?

[tbordinat]

On Chrome and Firefox, I don't see any difference.

It's on the AdminLTE Demo Page so I think it's well tested :)

Thanks for your tip, it can do the job temporary, but I also think that we have to fix it properly!

[kevinpapst]

Found that in the AdminLTE css files:

.hold-transition .content-wrapper,
.hold-transition .right-side,
.hold-transition .main-footer,
.hold-transition .main-sidebar,
.hold-transition .left-side,
.hold-transition .main-header .navbar,
.hold-transition .main-header .logo,
.hold-transition .menu-open .fa-angle-left {
  /* Fix for IE */
  -webkit-transition: none;
  -o-transition: none;
  transition: none;
}

Then lets simply merge.

[kevinpapst]

Released 3.2.4 - thanks @Ultiiiiii 👍
https://github.com/kevinpapst/AdminLTEBundle/releases/tag/3.2.4

[tbordinat]

Well, thank you for your availability!