Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Set knp_menu.enable as a boolean instead of scalar #143

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

tbordinat
Copy link
Contributor

Setting something else than a boolean ends in an exception about the next element, "main_menu"

An exception has been thrown during the rendering of a template ("The menu "adminlte_main" is not defined.").

With the enable attribute as a boolean, the exception is now understandable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code is used in AdminLTEBundle and will be published under the MIT license

Setting something else than a boolean ends in an exception about the next element, "main_menu"

    An exception has been thrown during the rendering of a template ("The menu "adminlte_main" is not defined.").

With the enable attribute as a boolean, the exception is now understandable.
@kevinpapst
Copy link
Owner

Thanks @Ultiiiiii for another PR!
I will give this a try soon and come back to you in the next days.

@kevinpapst kevinpapst self-requested a review May 28, 2020 22:47
@tbordinat
Copy link
Contributor Author

tbordinat commented May 29, 2020

I had to abort my Skype demo because I typed enable instead of true .. :-(
Haha

@kevinpapst kevinpapst merged commit 1993c57 into kevinpapst:master Jun 8, 2020
@kevinpapst
Copy link
Owner

Thank you @Ultiiiiii 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants