Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Allow Safe Labels, fixed #131 #132

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Allow Safe Labels, fixed #131 #132

merged 2 commits into from
Feb 20, 2021

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Apr 30, 2020

Allows HTML labels, like dividers.

@kevinpapst
Copy link
Owner

kevinpapst commented May 16, 2020

That is a potentially risk for people, who use the bundle in an environment where the menu items are user generated.
I don't think this should be activated by default.
Either you add a configuration for it, with default = false or you simply overwrite the template in your app through bundle inheritance.

The configuration would be better, because then it is compatible with the upcoming AdminLTE v3.

@kevinpapst
Copy link
Owner

Simply add a safe_labels boolean node to https://github.com/kevinpapst/AdminLTEBundle/blob/master/DependencyInjection/Configuration.php#L116
and then use "allow_safe_labels": admin_lte_context.knp_menu.safe_labels

@kevinpapst kevinpapst merged commit 67183f1 into kevinpapst:master Feb 20, 2021
@kevinpapst
Copy link
Owner

Thanks, I finally tested it and it indeed safe to set. Thank you @tacman

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants