add method to remove MenuItem from menu

[lduer]

Contribution to #111

As I haven't worked with KnpMenu, I've only added the suggested Code from the Issue.

Is it correct to detect the MenuItem by $name?

And the KnpMenuBundle is no requirement, so I need to detect by Knp\Menu\MenuItem class as string?

if (is_subclass_of($item, 'Knp\Menu\MenuItem') && isset($this->menuRootItems[$item->getName()])) {
            unset($this->menuRootItems[$item->getName()]);

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I updated the documentation (see here)
• I agree that this code is used in AdminLTEBundle and will be published under the MIT license

[kevinpapst]

I am not sure without checking the code myself. The KnpMenu integration is something that was already there when I forked the bundle.

But I added KnpMenu support to the Demo application, you just have to clone/composer install & then switch this config key for testing:
https://github.com/kevinpapst/AdminLTEBundle-Demo/blob/master/config/packages/admint_lte.yaml#L41

[lduer]

Hi Kevin,
After checking the AdminLTEBundle-Demo, this is the result:

• removeItem() is working for the MenuEvent with the commited code.
• The KnpMenu uses the KnpMenuEvent and the KnpMenu already has a removeChildren()function inside the MenuItem-Class which is used there.

So I think the submitted code is enough.

[kevinpapst]

Awesome, thanks for the detailed test @lduer 👍

[kevinpapst]

I created a new release, if you need it asap: https://github.com/kevinpapst/AdminLTEBundle/releases/tag/3.1