Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

add .gitattributes file #105

Merged
merged 3 commits into from
Dec 28, 2019
Merged

add .gitattributes file #105

merged 3 commits into from
Dec 28, 2019

Conversation

gggeek
Copy link
Contributor

@gggeek gggeek commented Dec 16, 2019

Description

Implement issue #104 : add .gitattributes file to shrink the 'dist' version of the package

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code is used in AdminLTEBundle and will be published under the MIT license

@gggeek
Copy link
Contributor Author

gggeek commented Dec 16, 2019

Note: I am still a noobie with nodejs/yarn/webpack.
I am not sure if the files package.json and yarn.lock could also be removed from the 'dist' package, as the building of the AdminLTEBundle bundle assets is done before a release is made and pushed to github, or if they are necessary, as those assets are built when yarn/webpack are run in the top-level project...

@kevinpapst
Copy link
Owner

kevinpapst commented Dec 16, 2019

yarn.lock can be removed.
Frontend tooling is not my business as well, so I am not entirely sure if package.json might be used by any tool. I'd say no, but I am not entirely sure, so lets keep it for now.

@gggeek
Copy link
Contributor Author

gggeek commented Dec 18, 2019

updated

.gitattributes Outdated Show resolved Hide resolved
@kevinpapst
Copy link
Owner

@gggeek
Copy link
Contributor Author

gggeek commented Dec 18, 2019

I think those should remain included in the dist tarball, as they are useful to the developer who wants to use this bundle

@kevinpapst kevinpapst merged commit 6445731 into kevinpapst:master Dec 28, 2019
@kevinpapst
Copy link
Owner

thanks @gggeek 👍

st0nebridge added a commit to st0nebridge/AdminLTEBundle that referenced this pull request Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants