Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deck and note options. #12

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add deck and note options. #12

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
28766a3
Add deck options via new OptionsGroup class.
holocronweaver Aug 17, 2017
eab7246
Add per-note options and a deck creation time.
holocronweaver Aug 18, 2017
685d962
Ensure deck creation time is an integer.
holocronweaver Aug 18, 2017
ebacc3c
Fix a few typos and a minor interface inconsistency.
holocronweaver Aug 18, 2017
cd261da
Rename note.level -> stage to reduce ambiguity.
holocronweaver Aug 18, 2017
6eb44fa
Minor coding style improvement.
holocronweaver Aug 19, 2017
96606ec
Document deck and note options.
holocronweaver Aug 24, 2017
0fa1870
Internally document note and deck options further.
holocronweaver Aug 24, 2017
a5a8d00
Fix a couple field name typos in apgk_col.
holocronweaver Aug 24, 2017
4d0449a
Update tests to create OptionGroups.
holocronweaver Aug 24, 2017
61b18b5
Add Card.status to allow suspending and burying cards.
holocronweaver Aug 28, 2017
bda7097
Move note options to CardOptions and try to match database field names.
holocronweaver Sep 1, 2017
8286fbc
Merge 'upstream/master' into options.
holocronweaver Sep 1, 2017
0a13191
Remove CardOptions and set options directly on Card or via Note.
holocronweaver Sep 2, 2017
d9fd190
Avoid relative commits in __init__.py
holocronweaver Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests to create OptionGroups.
  • Loading branch information
@holocronweaver
holocronweaver committed Aug 24, 2017
commit 4d0449a205204432e234339ad4a06a993ada60f5
12 changes: 8 additions & 4 deletions tests/test_genanki.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ def import_package(self, pkg):
importer.run()

def test_generated_deck_can_be_imported(self):
deck = genanki.Deck(123456, 'foodeck')
options = genanki.OptionsGroup(654321, 'foooptions')
deck = genanki.Deck(123456, 'foodeck', options)
note = genanki.Note(TEST_MODEL, ['a', 'b'])
deck.add_note(note)

Expand All @@ -121,7 +122,8 @@ def test_generated_deck_has_valid_cards(self):

Catches a bug that was fixed in 08d8a139.
"""
deck = genanki.Deck(123456, 'foodeck')
options = genanki.OptionsGroup(654321, 'foooptions')
deck = genanki.Deck(123456, 'foodeck', options)
deck.add_note(genanki.Note(TEST_CN_MODEL, ['a', 'b', 'c'])) # 2 cards
deck.add_note(genanki.Note(TEST_CN_MODEL, ['d', 'e', 'f'])) # 2 cards
deck.add_note(genanki.Note(TEST_CN_MODEL, ['g', 'h', 'i'])) # 2 cards
Expand All @@ -135,7 +137,8 @@ def test_generated_deck_has_valid_cards(self):

def test_card_isEmpty__with_2_fields__succeeds(self):
"""Tests for a bug in an early version of genanki where notes with <4 fields were not supported."""
deck = genanki.Deck(123456, 'foodeck')
options = genanki.OptionsGroup(654321, 'foooptions')
deck = genanki.Deck(123456, 'foodeck', options)
note = genanki.Note(TEST_MODEL, ['a', 'b'])
deck.add_note(note)

Expand Down Expand Up @@ -192,7 +195,8 @@ def test_media_files(self):
# change to a scratch directory so we can write files
os.chdir(tempfile.mkdtemp())

deck = genanki.Deck(123456, 'foodeck')
options = genanki.OptionsGroup(654321, 'foooptions')
deck = genanki.Deck(123456, 'foodeck', options)
note = genanki.Note(TEST_MODEL, [
'question [sound:present.mp3] [sound:missing.mp3]',
'answer <img src="present.jpg"> <img src="missing.jpg">'])
Expand Down