Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recompile with -fPIC #41

Open
rytis-paskauskas opened this issue Jan 18, 2019 · 34 comments
Open

recompile with -fPIC #41

rytis-paskauskas opened this issue Jan 18, 2019 · 34 comments
Labels
bug Something isn't working

Comments

@rytis-paskauskas
Copy link

$ make
...
[ 15%] Linking CXX executable pdfalto
/usr/bin/ld: libs/image/png/linux/libpng.a(png.c.o): relocation R_X86_64_32 against `.rodata' can not be used when making a PIE object; recompile with -fPIC
....

$ cc -v
Using built-in specs.
COLLECT_GCC=cc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --enable-libmpx --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --enable-cet=auto
Thread model: posix
gcc version 8.2.1 20181127 (GCC)

Any ideas?
Thanks,
Rytis
@Aazhar
Copy link
Collaborator

Aazhar commented Jan 18, 2019

Thank you for this feedback.
Could send the output of this command :

uname -i

@Aazhar
Copy link
Collaborator

Aazhar commented Jan 18, 2019

you need to generate build file using the flag PIC as showed in the error.
So you need to run cmake this way :

cmake "-DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=true" .

@rytis-paskauskas
Copy link
Author

rytis-paskauskas commented Jan 20, 2019 via email

@rytis-paskauskas
Copy link
Author

$ uname -i
unknown
$ uname -a
Linux ... 4.19.13-1-lts #1 SMP Sun Dec 30 07:38:47 CET 2018 x86_64 GNU/Linux

@Aazhar
Copy link
Collaborator

Aazhar commented Jan 20, 2019

Thanks for the information,
I can't reproduce this error in my environment, but I think you need to regenerate the libpng.a.
To do so you to go under libs/image/png/src and run :

cmake "-DCMAKE_POSITION_INDEPENDENT_CODE:BOOL=true" ./; make

This will generate a libpng.a file that you need to copy under libs/image/png/linux , since I understand you are using linux.

Please keep me informed.

@rytis-paskauskas
Copy link
Author

rytis-paskauskas commented Jan 21, 2019 via email

Aazhar pushed a commit that referenced this issue Jan 22, 2019
Update dependencies, fix issue #41
4696628
@Aazhar
Copy link
Collaborator

Aazhar commented Jan 22, 2019

Could you update your repository and re make it.

@Aazhar Aazhar added the bug Something isn't working label Jan 22, 2019
@rytis-paskauskas
Copy link
Author

rytis-paskauskas commented Jan 22, 2019 via email

Aazhar pushed a commit that referenced this issue Jan 23, 2019
Revert "Update dependencies, fix issue #41"
eca2d0c 
This reverts commit 4696628.
@Aazhar
Copy link
Collaborator

Aazhar commented Jan 23, 2019

Ok, it seems that your linker is old.
Could you send the output of this

ld -v

@Aazhar
Copy link
Collaborator

Aazhar commented Jan 23, 2019

What I suggest is you checkout the last updates and you compile the dependencies following the description here : https://github.com/kermitt2/pdfalto/blob/master/Dependencies_INSTALL.md

@rytis-paskauskas
Copy link
Author

$ ld -v
GNU ld (GNU Binutils) 2.31.1

I think you'll agree that my linker is not 'old'.

Thanks for writing up the 'do it yourself' instructions even though the approach is hardly ideal to solve one's software's portability issues.

@Aazhar
Copy link
Collaborator

Aazhar commented Jan 29, 2019

I've a bash script for installing the dependencies in one step , you can recompile all of the dependencies using this bash script https://github.com/kermitt2/pdfalto/blob/master/install_deps.sh

@Aazhar
Copy link
Collaborator

Aazhar commented Feb 18, 2019

Hello,
Any updates about this issue, have you installed the dependencies using the shell script ?

@naufraghi
Copy link

On Arch Linux I have the same issue, to use the provided libs I used an ubuntu:16.04 container:

docker run -v $PWD:/mnt --rm -it ubuntu:16.04 bash -c "apt-get update -qq; apt-get install -qq cmake build-essential clang git; git clone --depth=50 --branch=master https://github.com/kermitt2/pdfalto.git --recursive; (cd pdfalto; cmake ./; make; cp pdfalto /mnt);" && sudo chown $(id -u):$(id -g) pdfalto

@Aazhar
Copy link
Collaborator

Aazhar commented Feb 18, 2019

If you are encountering the same issue regarding the dependencies please refer to this section : https://github.com/kermitt2/pdfalto#dependencies
To fix this issue you'll need to run this script : https://github.com/kermitt2/pdfalto/blob/master/install_deps.sh

@Aazhar
Copy link
Collaborator

Aazhar commented Mar 4, 2019

hello @rytis-paskauskas
Could you give some updates about this issue

@rytis-paskauskas
Copy link
Author

Hi,
sorry for the delay. To make it up for it, I ran two OSs: Arch and the latest Debian. Following a clean checkout.
Arch: failed (libpaper)
Debian: success

Here is the relevant output on Arch:
$ cmake ./
++ 64 bit architecture
-- Found FreeType (old-style includes): /opt/src/pdfalto/libs/freetype/linux/64/libfreetype.a
-- lcms2 not found
-- Configuring done
-- Generating done
-- Build files have been written to: /opt/src/pdfalto

$ ./install_deps.sh
..... lots of warnings but no errors

$ make
[ 36%] Built target xpdf
[ 42%] Built target goo_objs
[ 43%] Built target goo
[ 48%] Built target fofi_objs
[ 48%] Built target fofi
[ 60%] Built target splash_objs
[ 61%] Built target splash
[ 62%] Linking CXX executable pdfalto
/usr/bin/ld: xpdf-4.00/build/xpdf/lib/libxpdf.a(GlobalParams.cc.o): in function GlobalParams::GlobalParams(char const*)': GlobalParams.cc:(.text+0xd81): undefined reference to paperinit'
/usr/bin/ld: GlobalParams.cc:(.text+0xd86): undefined reference to systempapername' /usr/bin/ld: GlobalParams.cc:(.text+0xda2): undefined reference to paperinfo'
/usr/bin/ld: GlobalParams.cc:(.text+0xdb2): undefined reference to paperpswidth' /usr/bin/ld: GlobalParams.cc:(.text+0xdc9): undefined reference to paperpsheight'
/usr/bin/ld: GlobalParams.cc:(.text+0xe0e): undefined reference to `paperdone'
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/pdfalto.dir/build.make:184: pdfalto] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/pdfalto.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

[rytis@pappa pdfalto] $ pacman -Ss libpaper
extra/libpaper 1.1.24-11 [installed]
Library for handling paper characteristics
$ pacman -Ql libpaper
libpaper /etc/
libpaper /etc/libpaper.d/
libpaper /etc/papersize
libpaper /usr/
libpaper /usr/bin/
libpaper /usr/bin/paperconf
libpaper /usr/bin/paperconfig
libpaper /usr/include/
libpaper /usr/include/paper.h
libpaper /usr/lib/
libpaper /usr/lib/libpaper.so
libpaper /usr/lib/libpaper.so.1
libpaper /usr/lib/libpaper.so.1.1.2
....

On Debian all went well.

Aazhar pushed a commit that referenced this issue Mar 6, 2019
Typos and fix libpaper check #41.
392fb53
@Aazhar
Copy link
Collaborator

Aazhar commented Mar 6, 2019

Thanks for your feedback, I've corrected it, it should be ok by now.

@Vitaliy-1
Copy link

Hi @Aazhar

I'm getting the same error actually. The script execution ends up with:

Copying libraries into their corresponding location.
cp: cannot stat 'install/libxml2-2.9.8/.libs/libxml2.a': No such file or directory
done.

@Vitaliy-1
Copy link

During the process

Checking zlib
./configure: line 13059: syntax error near unexpected token `Z,zlib,'
./configure: line 13059: `        PKG_CHECK_MODULES(Z,zlib,'
make: *** No targets specified and no makefile found.  Stop.
libxml2 installation is finished.

@Vitaliy-1
Copy link

Nevermind.
sudo apt install pkg-config

@cassebas
Copy link

cassebas commented Apr 4, 2019

Hi, I was having the same "relocation R_X86_64_32 against" errors. I'm on Debian stretch:

vagrant@stretch:~/git/pdfalto$ uname -a
Linux stretch 4.9.0-8-amd64 #1 SMP Debian 4.9.144-3 (2019-02-02) x86_64 GNU/Linux

I think all errors are from trying to link the libicuuc.a static library:

/usr/bin/ld: libs/icu/linux/64/libicuuc.a(uobject.ao): relocation R_X86_64_32 against symbol `__gxx_personality_v0' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(cmemory.ao): relocation R_X86_64_32 against `.rodata._ZL7zeroMem' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(unistr.ao): relocation R_X86_64_32 against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(ustring.ao): relocation R_X86_64_32S against `.rodata._ZL12UNESCAPE_MAP' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(ustrtrns.ao): relocation R_X86_64_32S against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
.. many more ..

I did use the install_deps.sh script, so I didn't know how to solve this with a pie executable.
Therefore I tried another solution, I added this to CMakeLists.txt:

   set(CMAKE_EXE_LINKER_FLAGS "-no-pie")

And this solved my problem:-)

@nisharepo
Copy link

set(CMAKE_EXE_LINKER_FLAGS "-no-pie") is not working for me i am getting the same error

/usr/bin/ld: /usr/local/lib/libbcrypt.a(wrapper.c.o): relocation R_X86_64_PC32 against symbol `_crypt_itoa64' can not be used when making a shared object; recompile with -fPIC

@prashantsathe
Copy link

Hi, I was having the same "relocation R_X86_64_32 against" errors. I'm on Debian stretch:

vagrant@stretch:~/git/pdfalto$ uname -a
Linux stretch 4.9.0-8-amd64 #1 SMP Debian 4.9.144-3 (2019-02-02) x86_64 GNU/Linux

I think all errors are from trying to link the libicuuc.a static library:

/usr/bin/ld: libs/icu/linux/64/libicuuc.a(uobject.ao): relocation R_X86_64_32 against symbol `__gxx_personality_v0' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(cmemory.ao): relocation R_X86_64_32 against `.rodata._ZL7zeroMem' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(unistr.ao): relocation R_X86_64_32 against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(ustring.ao): relocation R_X86_64_32S against `.rodata._ZL12UNESCAPE_MAP' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(ustrtrns.ao): relocation R_X86_64_32S against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
.. many more ..

I did use the install_deps.sh script, so I didn't know how to solve this with a pie executable.
Therefore I tried another solution, I added this to CMakeLists.txt:

   set(CMAKE_EXE_LINKER_FLAGS "-no-pie")

And this solved my problem:-)

I was facing the same issue with other project

Hi, I was having the same "relocation R_X86_64_32 against" errors. I'm on Debian stretch:

vagrant@stretch:~/git/pdfalto$ uname -a
Linux stretch 4.9.0-8-amd64 #1 SMP Debian 4.9.144-3 (2019-02-02) x86_64 GNU/Linux

I think all errors are from trying to link the libicuuc.a static library:

/usr/bin/ld: libs/icu/linux/64/libicuuc.a(uobject.ao): relocation R_X86_64_32 against symbol `__gxx_personality_v0' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(cmemory.ao): relocation R_X86_64_32 against `.rodata._ZL7zeroMem' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(unistr.ao): relocation R_X86_64_32 against `.bss' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(ustring.ao): relocation R_X86_64_32S against `.rodata._ZL12UNESCAPE_MAP' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: libs/icu/linux/64/libicuuc.a(ustrtrns.ao): relocation R_X86_64_32S against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
.. many more ..

I did use the install_deps.sh script, so I didn't know how to solve this with a pie executable.
Therefore I tried another solution, I added this to CMakeLists.txt:

   set(CMAKE_EXE_LINKER_FLAGS "-no-pie")

And this solved my problem:-)

Lifesaver. I was facing the same issue with another project.
set(CMAKE_EXE_LINKER_FLAGS "-no-pie") 💯 👍

@mcuadros
Copy link

mcuadros commented Jun 9, 2021

Using a clean environment in docker I get exactly the same error. This is the sript I am executing

FROM debian:buster-slim as builder


RUN DEBIAN_FRONTEND=noninteractive \
    apt-get update && \
    apt-get install -y --no-install-recommends \
        ca-certificates wget sudo autoconf automake pkg-config cmake build-essential clang git && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

RUN git config --global url."https://github.com/".insteadOf [email protected]: && \
    git clone --depth=50 --branch=master https://github.com/kermitt2/pdfalto.git --recursive

WORKDIR pdfalto
RUN ./install_deps.sh
RUN cmake ./ && make

@andreasbaumann
Copy link

andreasbaumann commented Jan 17, 2022 •
edited

Aeh, you are downloading static libraries (usually illegal on many distros) and just linking against a libxml.a built
with whatever flags? This will totally not work and injects binary artifacts checked in into git of unknown source into the build!

Please link against the system libxml2 (which links against the correct system icu) or compile all sources from scratch as
subprojects (but why would you want to do that? If your version of xpdf is relying on old versions of standard libraries you should consider adapting the code).

This applies for all other libraries too:

set ( XML_LIBRARY ${XML_LIB_SUBDIR}/${OSSUFFIX}/${ARCHSUFFIX}/libxml2.a)
set ( PNG_LIBRARIES ${PNG_SUBDIR}/${OSSUFFIX}/${ARCHSUFFIX}/libpng.a)
set ( ZLIB_LIBRARY ${ZLIB_SUBDIR}/${OSSUFFIX}/${ARCHSUFFIX}/libzlib.a)
set ( FREETYPE_LIBRARY ${CMAKE_CURRENT_SOURCE_DIR}/libs/freetype/${OSSUFFIX}/${ARCHSUFFIX}/libfreetype.a)
set ( ICUUC_LIB ${CMAKE_CURRENT_SOURCE_DIR}/libs/icu/${OSSUFFIX}/${ARCHSUFFIX}/libicuuc.a)
set ( ICUDATA_LIB ${CMAKE_CURRENT_SOURCE_DIR}/libs/icu/${OSSUFFIX}/${ARCHSUFFIX}/libicudata.a)

@andreasbaumann
Copy link

Ok, I tried to patch and package it for Archlinux, so that it builds fine with system libraries. The result is here:
https://aur.archlinux.org/packages/pdfalto/

@kermitt2
Copy link
Owner

Thank you @andreasbaumann for your message

In this build, we are not trying to make a linux redistribution package that will be further linked by other library (it would be another build scenario). Here we are building a standalone executable to be portable and packaged in other tools (to avoid having the users of these tools to install pdfalto on their system and deal with library compatibility).

So our motivation here is not to link dynamically with the system libraries and not building something to be further linked with something else (afaik there is compiler and flag compatibility issues in this case).

you are downloading static libraries (usually illegal on many distros)

Could you elaborate why it would be illegal or point to some explanations? To my understanding, there is no problem to add to a GitHub repo some static libraries built from GPL compatible sources in a GPL project.

... injects binary artifacts checked in into git of unknown source into the build

The sources correspond to the script https://github.com/kermitt2/pdfalto/blob/master/install_deps.sh
Again the goal here is to facilitate a static build that can be embedded in other tools with minimal dependencies, not to create a linux package.

@andreasbaumann
Copy link

andreasbaumann commented Jan 17, 2022 •
edited

Well, illegal is a harsh term, sorry. :-)

Statically linked libraries have been built with all kind of flags affecting the ABI (PIC, PIE, stack smashing,
optimization flags, etc.), so it might not link on the target machine or expose strange behaviour.

Static libraries might pose a security risk, imagine a vulnerabilty gets fixed in libpng, but you still link statically against
an old version containing the vulerability.

The whole idea of doing packaging of software is to easy the installation for normal Linux users. But you leave the
last step of linking and building pdfalto to the end user, which results in the errors as seen above.

You end up in bitrot (for instance your C++ code depends on old deprecated APIs of libpng), which is not good
for the code quality on the long term.

@kermitt2
Copy link
Owner

@andreasbaumann So "bad practices" rather than illegal, I feel better with that :)

Thanks a lot for the Archlinux package, this is great contribution! Could you maybe suggest some notes about it to be added in the readme? Or I can just point to https://aur.archlinux.org/packages/pdfalto/ ?

I totally agree with you about packaging and that a statically link library is very bad distributable, sure. But this build was not intended for distributing a library, it's for building an executable that can work on a variety of outdated linux distro 64 bits and macos without any install for the end user (most would not do it). This is the scenario we needed pdfalto, which explains why we focused on it.

For doing this, I don't see how we can avoid freezing the dependencies as static libraries, this is pro and cons of static vs dynamic. Would you have suggestions how to improve building a portable executable ?

@andreasbaumann
Copy link

Yeah, this URL will do just fine. :-)

At least I would add the sources as 3rdParty git modules, so that you know where those binaries came from
(and in the worst case, they can be changed and rebuild). Or just have a README about how to rebuild it
from source.

@kermitt2
Copy link
Owner

Thank you @andreasbaumann

There is actually a README on building from sources -> https://github.com/kermitt2/pdfalto/blob/master/Dependencies_INSTALL.md (although libpng & zlib are from local source :/ )

Then the problem is that the availability of these sources as git module. For instance I had to create and update a git repo for xpdf myself to be able to add it as a git module - so it is only moving the maintenance problem elsewhere... but I can try to look again when I will update the pdfalto project in the next weeks/months.

@kermitt2
Copy link
Owner

... readme update for ArchLinux package adacaac

@andreasbaumann
Copy link

Perfekt, thanks for being so patient with me. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@naufraghi @andreasbaumann @mcuadros @kermitt2 @Aazhar @prashantsathe @rytis-paskauskas @cassebas @Vitaliy-1 @nisharepo