chore(deps): update cross-spawn and trash-cli

[zhuangya]

No description provided.

[kentcdodds]

Should we remove this now?

[zhuangya]

updated :)

[zhuangya]

updated :)

On Thu, May 19, 2016 at 9:33 PM, Kent C. Dodds [email protected]
wrote:

In package.json
#14 (comment):

@@ -62,6 +62,7 @@
}
},
"dependencies": {

• "cross-spawn": "^3.0.1",
  "cross-spawn-async": "2.0.0",

Should we remove this now?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/kentcdodds/cross-env/pull/14/files/0d755a90a7de1bca72403e957eaffacaa69043c7#r63878305

[kentcdodds]

Hi @zhuangya. This PR looks great. I'm unsure of the benefit of using cross-spawn vs cross-spawn-async. They both look to be maintained by the same developer and they both received a release in the last 24 hours so they both look actively maintained. Could you explain the reasoning behind that update? Thanks!

[kentcdodds]

And actually, we should probably be using rimraf instead of trash so we don't fill up the Recycle bin... ¯_(ツ)_/¯

[zhuangya]

Yeah. No problem. But currently it's around 1 am in my timezone I really need to have some sleep
I'll change it later. -)
Sent using CloudMagic Email [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=7.11.40&pv=9.3.1&source=email_footer_2]
On 周五, 5月 20, 2016 at 01:23, Kent C. Dodds [email protected] wrote:
And actually, we should probably be using rimraf instead of trash so we don't fill up the Recycle bin... ¯_(ツ)_/¯

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub [https://github.com//pull/14#issuecomment-220393778]

[kentcdodds]

Cool, have a good night! 💤

Also, if you could explain why we need to change to cross-spawn, that'd be great :-)

[zhuangya]

trash => rimraf ✅

why switch to cross-spawn, cause cross-spawn-async is deprecated

[codecov-io]

Current coverage is 100%

Merging #14 into master will not change coverage

@@           master   #14   diff @@
===================================
  Files           1     1          
  Lines          32    32          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           32    32          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last updated by afc91b7...4146b27

[kentcdodds]

Thanks a bunch!

[zhuangya]

bump a new version on npm maybe?
thanks 😄

[kentcdodds]

Is there a reason that's necessary? It's working as is right?

[zhuangya]

❯ npm install cross-env
npm WARN deprecated [email protected]: cross-spawn no longer requires a build toolchain, use it instead!

[kentcdodds]

Ah, ok. I'll try to get something released soon. Thanks.

[zhuangya]

no hurry since everything works fine now.

nice day =)

On Tue, May 24, 2016 at 11:59 AM, Kent C. Dodds [email protected]
wrote:

Ah, ok. I'll try to get something released soon. Thanks.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#14 (comment)

[kentcdodds]

It should be released now. 👍