Skip to content

Commit

Permalink
Update core to latest, fix usage of Trace instead of Traces (open-tel…
Browse files Browse the repository at this point in the history
…emetry#3105)

Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu committed Apr 14, 2021
1 parent 8ded668 commit 020dc8c
Show file tree
Hide file tree
Showing 227 changed files with 453 additions and 453 deletions.
6 changes: 3 additions & 3 deletions exporter/alibabacloudlogserviceexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func NewFactory() component.ExporterFactory {
return exporterhelper.NewFactory(
typeStr,
createDefaultConfig,
exporterhelper.WithTraces(createTraceExporter),
exporterhelper.WithTraces(createTracesExporter),
exporterhelper.WithMetrics(createMetricsExporter),
exporterhelper.WithLogs(createLogsExporter))
}
Expand All @@ -44,12 +44,12 @@ func createDefaultConfig() config.Exporter {
}
}

func createTraceExporter(
func createTracesExporter(
_ context.Context,
params component.ExporterCreateParams,
cfg config.Exporter,
) (component.TracesExporter, error) {
return newTraceExporter(params.Logger, cfg)
return newTracesExporter(params.Logger, cfg)
}

func createMetricsExporter(
Expand Down
2 changes: 1 addition & 1 deletion exporter/alibabacloudlogserviceexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/gogo/protobuf v1.3.2
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327
go.uber.org/zap v1.16.0
gopkg.in/ini.v1 v1.57.0 // indirect
)
4 changes: 2 additions & 2 deletions exporter/alibabacloudlogserviceexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -908,8 +908,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e h1:jBdlkJx7nw6aGPSPq5YfTTOfnGXAdSzx9yNDoaTRC3A=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327 h1:Br2+gOanaGNcN5KUyJM56Flpf7ex3D/rZtAQkm1h3C0=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
6 changes: 3 additions & 3 deletions exporter/alibabacloudlogserviceexporter/trace_exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import (
"go.uber.org/zap"
)

// newTraceExporter return a new LogSerice trace exporter.
func newTraceExporter(logger *zap.Logger, cfg config.Exporter) (component.TracesExporter, error) {
// newTracesExporter return a new LogSerice trace exporter.
func newTracesExporter(logger *zap.Logger, cfg config.Exporter) (component.TracesExporter, error) {

l := &logServiceTraceSender{
logger: logger,
Expand All @@ -36,7 +36,7 @@ func newTraceExporter(logger *zap.Logger, cfg config.Exporter) (component.Traces
return nil, err
}

return exporterhelper.NewTraceExporter(
return exporterhelper.NewTracesExporter(
cfg,
logger,
l.pushTraceData)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ import (
"go.uber.org/zap"
)

func TestNewTraceExporter(t *testing.T) {
func TestNewTracesExporter(t *testing.T) {

got, err := newTraceExporter(zap.NewNop(), &Config{
got, err := newTracesExporter(zap.NewNop(), &Config{
ExporterSettings: config.NewExporterSettings(typeStr),
Endpoint: "cn-hangzhou.log.aliyuncs.com",
Project: "demo-project",
Expand All @@ -49,9 +49,9 @@ func TestNewTraceExporter(t *testing.T) {
assert.Nil(t, got.Shutdown(context.Background()))
}

func TestNewFailsWithEmptyTraceExporterName(t *testing.T) {
func TestNewFailsWithEmptyTracesExporterName(t *testing.T) {

got, err := newTraceExporter(zap.NewNop(), &Config{})
got, err := newTracesExporter(zap.NewNop(), &Config{})
assert.Error(t, err)
require.Nil(t, got)
}
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestCreateDefaultConfig(t *testing.T) {
assert.NoError(t, configcheck.ValidateConfig(cfg))
}

func TestCreateTraceExporter(t *testing.T) {
func TestCreateTracesExporter(t *testing.T) {
logger := zap.NewNop()

factories, err := componenttest.NopFactories()
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsemfexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws v0.0.0-00010101000000-000000000000
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327
go.uber.org/zap v1.16.0
google.golang.org/protobuf v1.26.0
gopkg.in/ini.v1 v1.57.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions exporter/awsemfexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1048,8 +1048,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e h1:jBdlkJx7nw6aGPSPq5YfTTOfnGXAdSzx9yNDoaTRC3A=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327 h1:Br2+gOanaGNcN5KUyJM56Flpf7ex3D/rZtAQkm1h3C0=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/otel v0.19.0 h1:Lenfy7QHRXPZVsw/12CWpxX6d/JkrX8wrx2vO8G80Ng=
go.opentelemetry.io/otel v0.19.0/go.mod h1:j9bF567N9EfomkSidSfmMwIwIBuP37AMAIzVW85OxSg=
go.opentelemetry.io/otel/metric v0.19.0/go.mod h1:8f9fglJPRnXuskQmKpnad31lcLJ2VmNNqIsx/uIwBSc=
Expand Down
4 changes: 2 additions & 2 deletions exporter/awskinesisexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func NewFactory() component.ExporterFactory {
return exporterhelper.NewFactory(
typeStr,
createDefaultConfig,
exporterhelper.WithTraces(createTraceExporter))
exporterhelper.WithTraces(createTracesExporter))
}

func createDefaultConfig() config.Exporter {
Expand All @@ -59,7 +59,7 @@ func createDefaultConfig() config.Exporter {
}
}

func createTraceExporter(
func createTracesExporter(
_ context.Context,
params component.ExporterCreateParams,
config config.Exporter,
Expand Down
2 changes: 1 addition & 1 deletion exporter/awskinesisexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/signalfx/opencensus-go-exporter-kinesis v0.6.3
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327
go.uber.org/zap v1.16.0
gopkg.in/ini.v1 v1.57.0 // indirect
)
4 changes: 2 additions & 2 deletions exporter/awskinesisexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1078,8 +1078,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e h1:jBdlkJx7nw6aGPSPq5YfTTOfnGXAdSzx9yNDoaTRC3A=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327 h1:Br2+gOanaGNcN5KUyJM56Flpf7ex3D/rZtAQkm1h3C0=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsprometheusremotewriteexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/onsi/gomega v1.10.2 // indirect
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327
go.uber.org/zap v1.16.0
gopkg.in/ini.v1 v1.57.0 // indirect
)
4 changes: 2 additions & 2 deletions exporter/awsprometheusremotewriteexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1048,8 +1048,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e h1:jBdlkJx7nw6aGPSPq5YfTTOfnGXAdSzx9yNDoaTRC3A=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327 h1:Br2+gOanaGNcN5KUyJM56Flpf7ex3D/rZtAQkm1h3C0=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
8 changes: 4 additions & 4 deletions exporter/awsxrayexporter/awsxray.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ const (
maxSegmentsPerPut = int(50) // limit imposed by PutTraceSegments API
)

// newTraceExporter creates an component.TraceExporter that converts to an X-Ray PutTraceSegments
// newTracesExporter creates an component.TracesExporter that converts to an X-Ray PutTraceSegments
// request and then posts the request to the configured region's X-Ray endpoint.
func newTraceExporter(
func newTracesExporter(
config config.Exporter, params component.ExporterCreateParams, cn connAttr) (component.TracesExporter, error) {
typeLog := zap.String("type", string(config.Type()))
nameLog := zap.String("name", config.Name())
Expand All @@ -45,12 +45,12 @@ func newTraceExporter(
return nil, err
}
xrayClient := newXRay(logger, awsConfig, params.ApplicationStartInfo, session)
return exporterhelper.NewTraceExporter(
return exporterhelper.NewTracesExporter(
config,
logger,
func(ctx context.Context, td pdata.Traces) error {
var err error
logger.Debug("TraceExporter", typeLog, nameLog, zap.Int("#spans", td.SpanCount()))
logger.Debug("TracesExporter", typeLog, nameLog, zap.Int("#spans", td.SpanCount()))
documents := make([]*string, 0, td.SpanCount())
for i := 0; i < td.ResourceSpans().Len(); i++ {
rspans := td.ResourceSpans().At(i)
Expand Down
10 changes: 5 additions & 5 deletions exporter/awsxrayexporter/awsxray_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
)

func TestTraceExport(t *testing.T) {
traceExporter := initializeTraceExporter()
traceExporter := initializeTracesExporter()
ctx := context.Background()
td := constructSpanData()
err := traceExporter.ConsumeTraces(ctx, td)
Expand All @@ -40,8 +40,8 @@ func TestTraceExport(t *testing.T) {
assert.Nil(t, err)
}

func BenchmarkForTraceExporter(b *testing.B) {
traceExporter := initializeTraceExporter()
func BenchmarkForTracesExporter(b *testing.B) {
traceExporter := initializeTracesExporter()
for i := 0; i < b.N; i++ {
b.StopTimer()
ctx := context.Background()
Expand All @@ -51,7 +51,7 @@ func BenchmarkForTraceExporter(b *testing.B) {
}
}

func initializeTraceExporter() component.TracesExporter {
func initializeTracesExporter() component.TracesExporter {
os.Setenv("AWS_ACCESS_KEY_ID", "AKIASSWVJUY4PZXXXXXX")
os.Setenv("AWS_SECRET_ACCESS_KEY", "XYrudg2H87u+ADAAq19Wqx3D41a09RsTXXXXXXXX")
os.Setenv("AWS_DEFAULT_REGION", "us-east-1")
Expand All @@ -63,7 +63,7 @@ func initializeTraceExporter() component.TracesExporter {
config.(*Config).LocalMode = true
mconn := new(mockConn)
mconn.sn, _ = getDefaultSession(logger)
traceExporter, err := newTraceExporter(config, component.ExporterCreateParams{Logger: logger}, mconn)
traceExporter, err := newTracesExporter(config, component.ExporterCreateParams{Logger: logger}, mconn)
if err != nil {
panic(err)
}
Expand Down
6 changes: 3 additions & 3 deletions exporter/awsxrayexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func NewFactory() component.ExporterFactory {
return exporterhelper.NewFactory(
typeStr,
createDefaultConfig,
exporterhelper.WithTraces(createTraceExporter))
exporterhelper.WithTraces(createTracesExporter))
}

func createDefaultConfig() config.Exporter {
Expand All @@ -51,11 +51,11 @@ func createDefaultConfig() config.Exporter {
}
}

func createTraceExporter(
func createTracesExporter(
_ context.Context,
params component.ExporterCreateParams,
cfg config.Exporter,
) (component.TracesExporter, error) {
eCfg := cfg.(*Config)
return newTraceExporter(eCfg, params, &Conn{})
return newTracesExporter(eCfg, params, &Conn{})
}
2 changes: 1 addition & 1 deletion exporter/awsxrayexporter/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestCreateDefaultConfig(t *testing.T) {
assert.NoError(t, configcheck.ValidateConfig(cfg))
}

func TestCreateTraceExporter(t *testing.T) {
func TestCreateTracesExporter(t *testing.T) {
logger := zap.NewNop()

factories, err := componenttest.NopFactories()
Expand Down
2 changes: 1 addition & 1 deletion exporter/awsxrayexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ require (
github.com/open-telemetry/opentelemetry-collector-contrib/internal/awsxray v0.0.0-00010101000000-000000000000
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327
go.uber.org/zap v1.16.0
golang.org/x/net v0.0.0-20210119194325-5f4716e94777
gopkg.in/ini.v1 v1.57.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions exporter/awsxrayexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1048,8 +1048,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e h1:jBdlkJx7nw6aGPSPq5YfTTOfnGXAdSzx9yNDoaTRC3A=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327 h1:Br2+gOanaGNcN5KUyJM56Flpf7ex3D/rZtAQkm1h3C0=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
6 changes: 3 additions & 3 deletions exporter/azuremonitorexporter/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func NewFactory() component.ExporterFactory {
return exporterhelper.NewFactory(
typeStr,
createDefaultConfig,
exporterhelper.WithTraces(f.createTraceExporter))
exporterhelper.WithTraces(f.createTracesExporter))
}

// Implements the interface from go.opentelemetry.io/collector/exporter/factory.go
Expand All @@ -59,7 +59,7 @@ func createDefaultConfig() config.Exporter {
}
}

func (f *factory) createTraceExporter(
func (f *factory) createTracesExporter(
ctx context.Context,
params component.ExporterCreateParams,
cfg config.Exporter,
Expand All @@ -71,7 +71,7 @@ func (f *factory) createTraceExporter(
}

tc := f.getTransportChannel(exporterConfig, params.Logger)
return newTraceExporter(exporterConfig, tc, params.Logger)
return newTracesExporter(exporterConfig, tc, params.Logger)
}

// Configures the transport channel.
Expand Down
12 changes: 6 additions & 6 deletions exporter/azuremonitorexporter/factory_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,30 +29,30 @@ type badConfig struct {
config.ExporterSettings `mapstructure:",squash"`
}

func TestCreateTraceExporterUsingSpecificTransportChannel(t *testing.T) {
func TestCreateTracesExporterUsingSpecificTransportChannel(t *testing.T) {
// mock transport channel creation
f := factory{tChannel: &mockTransportChannel{}}
ctx := context.Background()
params := component.ExporterCreateParams{Logger: zap.NewNop()}
exporter, err := f.createTraceExporter(ctx, params, createDefaultConfig())
exporter, err := f.createTracesExporter(ctx, params, createDefaultConfig())
assert.NotNil(t, exporter)
assert.Nil(t, err)
}

func TestCreateTraceExporterUsingDefaultTransportChannel(t *testing.T) {
func TestCreateTracesExporterUsingDefaultTransportChannel(t *testing.T) {
// We get the default transport channel creation, if we don't specify one during f creation
f := factory{}
assert.Nil(t, f.tChannel)
ctx := context.Background()
logger, _ := zap.NewDevelopment()
params := component.ExporterCreateParams{Logger: logger}
exporter, err := f.createTraceExporter(ctx, params, createDefaultConfig())
exporter, err := f.createTracesExporter(ctx, params, createDefaultConfig())
assert.NotNil(t, exporter)
assert.Nil(t, err)
assert.NotNil(t, f.tChannel)
}

func TestCreateTraceExporterUsingBadConfig(t *testing.T) {
func TestCreateTracesExporterUsingBadConfig(t *testing.T) {
// We get the default transport channel creation, if we don't specify one during factory creation
f := factory{}
assert.Nil(t, f.tChannel)
Expand All @@ -61,7 +61,7 @@ func TestCreateTraceExporterUsingBadConfig(t *testing.T) {

badConfig := &badConfig{}

exporter, err := f.createTraceExporter(ctx, params, badConfig)
exporter, err := f.createTracesExporter(ctx, params, badConfig)
assert.Nil(t, exporter)
assert.NotNil(t, err)
}
2 changes: 1 addition & 1 deletion exporter/azuremonitorexporter/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ require (
github.com/pelletier/go-toml v1.8.0 // indirect
github.com/stretchr/testify v1.7.0
github.com/tedsuo/ifrit v0.0.0-20191009134036-9a97d0632f00 // indirect
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327
go.uber.org/zap v1.16.0
golang.org/x/net v0.0.0-20210119194325-5f4716e94777
gopkg.in/ini.v1 v1.57.0 // indirect
Expand Down
4 changes: 2 additions & 2 deletions exporter/azuremonitorexporter/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1058,8 +1058,8 @@ go.opencensus.io v0.22.4/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
go.opencensus.io v0.22.5/go.mod h1:5pWMHQbX5EPX2/62yrJeAkowc+lfs/XD7Uxpq3pI6kk=
go.opencensus.io v0.23.0 h1:gqCw0LfLxScz8irSi8exQc7fyQ0fKQU/qnC/X8+V/1M=
go.opencensus.io v0.23.0/go.mod h1:XItmlyltB5F7CS4xOC1DcqMoFqwtC6OG2xF7mCv7P7E=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e h1:jBdlkJx7nw6aGPSPq5YfTTOfnGXAdSzx9yNDoaTRC3A=
go.opentelemetry.io/collector v0.24.1-0.20210414150520-7b9a2651fe8e/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327 h1:Br2+gOanaGNcN5KUyJM56Flpf7ex3D/rZtAQkm1h3C0=
go.opentelemetry.io/collector v0.24.1-0.20210414213607-0f75efa9f327/go.mod h1:hXpdip0pVo+lISHAzPtu13QIRHgqC1zZ/4EdgoEC0fc=
go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
Expand Down
4 changes: 2 additions & 2 deletions exporter/azuremonitorexporter/traceexporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ func (exporter *traceExporter) onTraceData(context context.Context, traceData pd
}

// Returns a new instance of the trace exporter
func newTraceExporter(config *Config, transportChannel transportChannel, logger *zap.Logger) (component.TracesExporter, error) {
func newTracesExporter(config *Config, transportChannel transportChannel, logger *zap.Logger) (component.TracesExporter, error) {

exporter := &traceExporter{
config: config,
transportChannel: transportChannel,
logger: logger,
}

return exporterhelper.NewTraceExporter(config, logger, exporter.onTraceData)
return exporterhelper.NewTracesExporter(config, logger, exporter.onTraceData)
}
Loading

0 comments on commit 020dc8c

Please sign in to comment.