Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to readme #67

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

challapradyumna
Copy link
Contributor

Updated documentation with available flags.

@challapradyumna challapradyumna requested a review from a team as a code owner January 6, 2021 09:22
@CLAassistant
Copy link

CLAassistant commented Jan 6, 2021

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Challa Pradyumna <[email protected]>
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #67 (b835f96) into master (71fbbbf) will decrease coverage by 2.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   72.08%   69.82%   -2.27%     
==========================================
  Files          12       12              
  Lines         996      898      -98     
==========================================
- Hits          718      627      -91     
+ Misses        216      211       -5     
+ Partials       62       60       -2     
Impacted Files Coverage Δ
pkg/service/deregistrator.go 43.93% <0.00%> (-3.95%) ⬇️
pkg/service/metrics.go 80.95% <0.00%> (-3.67%) ⬇️
pkg/service/sqs.go 69.23% <0.00%> (-3.50%) ⬇️
pkg/service/nodes.go 82.71% <0.00%> (-2.40%) ⬇️
pkg/service/autoscaling.go 76.47% <0.00%> (-2.11%) ⬇️
pkg/service/target.go 76.47% <0.00%> (-1.80%) ⬇️
pkg/service/events.go 82.85% <0.00%> (-1.76%) ⬇️
pkg/service/server.go 59.20% <0.00%> (-1.49%) ⬇️
pkg/service/manager.go 70.58% <0.00%> (-0.59%) ⬇️
pkg/service/elb.go 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fbbbf...b835f96. Read the comment docs.

@eytan-avisror
Copy link
Collaborator

Thanks for adding this @challapradyumna
Can you center the columns? I think you can do that by adding :--:, e.g.

| Name | Default | Type | Description |
|:------:|:---------:|:------:|:-------------:|

Signed-off-by: Challa Pradyumna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants