Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON payload inside message field of v1.Event #26

Merged
merged 7 commits into from
Nov 27, 2019
Merged

JSON payload inside message field of v1.Event #26

merged 7 commits into from
Nov 27, 2019

Conversation

vigith
Copy link
Contributor

@vigith vigith commented Nov 27, 2019

fixes #24

An example run looks something like this

$ k -n default get events -w
+ kubectl -n default get events -w
LAST SEEN   TYPE     REASON                          OBJECT                                              MESSAGE
53s         Normal   EventLifecycleHookReceived      node/ip-10-129-162-131.us-west-2.compute.internal   {"asgName":"iks-system.mpa-play-1.k8s.local","details":"lifecycle hook for event 9ca5bab9-fc84-92be-b133-bbe3dd6e8a30 was received, instance i-05faf90edc56de7d0 will begin processing","ec2InstanceId":"i-05faf90edc56de7d0","eventID":"9ca5bab9-fc84-92be-b133-bbe3dd6e8a30"}
49s         Normal   EventReasonNodeDrainSucceeded   node/ip-10-129-162-131.us-west-2.compute.internal   {"asgName":"iks-system.mpa-play-1.k8s.local","details":"node ip-10-129-162-131.us-west-2.compute.internal has been drained successfully as a response to a termination event","ec2InstanceId":"i-05faf90edc56de7d0","eventID":"9ca5bab9-fc84-92be-b133-bbe3dd6e8a30"}

@vigith vigith requested a review from a team as a code owner November 27, 2019 20:28
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #26 into master will decrease coverage by 2.28%.
The diff coverage is 53.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   73.64%   71.36%   -2.29%     
==========================================
  Files           8        8              
  Lines         592      646      +54     
==========================================
+ Hits          436      461      +25     
- Misses        107      135      +28     
- Partials       49       50       +1
Impacted Files Coverage Δ
pkg/service/server.go 62.42% <52.77%> (-3.25%) ⬇️
pkg/service/events.go 80.64% <57.14%> (-7.82%) ⬇️
pkg/service/elbv2.go 84.09% <0%> (+0.75%) ⬆️
pkg/service/elb.go 85% <0%> (+0.78%) ⬆️
pkg/service/autoscaling.go 82% <0%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79996d5...8926295. Read the comment docs.

Copy link
Collaborator

@eytan-avisror eytan-avisror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Any additional improvements to coverage (if possible) with this PR are welcome

vigith and others added 3 commits November 27, 2019 14:11
* add err ELBv2 stub
* gofmt

Signed-off-by: Vigith Maurice <[email protected]>
@eytan-avisror eytan-avisror merged commit 22ae935 into keikoproj:master Nov 27, 2019
@eytan-avisror eytan-avisror mentioned this pull request Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

structured v1.Event message for easy parsing
2 participants