Clear up RBAC #19
Merged
Clear up RBAC #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 73.56% 73.56%
=======================================
Files 8 8
Lines 575 575
=======================================
Hits 423 423
Misses 104 104
Partials 48 48Continue to review full report at Codecov.
|
eytan-avisror
approved these changes
Oct 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RBAC in the README.md and in the example yaml doesn't seem to match up. When using the example yaml, lifecycle-manager wasn't able to do certain things it needed to do when I first deployed it. I merged the two sets of RBAC rules in the example yaml and removed the README.md RBAC. Simply pointing people towards the yaml should be sufficient I reckon and keeps things in one place.