Content-Type header #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kralizek
suggested changes
Apr 16, 2019
src/EMG.Lambda.LocalRunner/Internal/InnerReceivingRunnerBuilder.cs
Outdated
Show resolved
Hide resolved
Kralizek
reviewed
Apr 16, 2019
There was a problem hiding this comment.
Great idea. I definitely agree that we should not have a major version bump.
I would just look at the sequence. It doens't make sense to specify the response content type if there is no response. The fluent builder should not give the user the possibility to specify options that are at best useless.
Also I would consider the possibility to have the serializer specify the content type, although this would mean moving away from the ILambdaSerializer interface.
Also, please update the README with an example.
Kralizek
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to the runner builder so the user can specify a value for the Content-Type header, that gets injected in responses when hosting functions that return a result.
It uses "application/json" as a default in case nothing is specified. This may be considered a breaking change, but I think it's a sane default nonetheless.