Remove typescript (and optimistic-minting) modules from the CI flow
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer want to publish new `typescript` testnet packages as part of the CI flow. The `typescript` project is transitioning to v2, which has all the chain configs embeded, so we'll no longer use the `mainnet` and `goerli` packages. All existing testnet packages were marked in the NPM registry as deprecated (projects still can use them as dependencies, but will get a warning).
lukasz-zimnoch
approved these changes
Nov 7, 2023
lukasz-zimnoch
added a commit
to keep-network/tbtc-v2
that referenced
this pull request
Nov 7, 2023
We no longer want to publish new `typescript` (`tbtc-v2.ts`) testnet packages as part of the CI flow. The Typescript project is transitioning to v2, which has all the chain configs embeded, so we'll no longer use the `mainnet` and `goerli` packages. The only tags will be `latest` and `development`. All existing testnet packages were marked in the NPM registry as deprecated (projects still can use them as dependencies, but will get a warning). Ref: keep-network/ci#49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer want to publish new
typescript(tbtc-v2.ts) testnet packages as part of the CI flow. Thetypescriptproject is transitioning to v2, which has all the chain configs embeded, so we'll no longer use themainnetandgoerlipackages. All existing testnet packages were marked in the NPM registry as deprecated (projects still can use them as dependencies, but will get a warning).As we won't be publishing new
typescriptpackages in CI flow anymore, there's no need to keepoptimisting-mintingthere as well.After the changes, the flow will look like this:
Ref: keep-network/tbtc-v2#724