Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update credentials example for S3 bucket specs #542

Merged
merged 4 commits into from
Oct 6, 2020

Conversation

vhawk19
Copy link
Contributor

@vhawk19 vhawk19 commented Oct 4, 2020

Description

Resolves #539

Update documentation for S3 bucket credentials example

Development notes

None, only docs/source updated.

Checklist

  • [x ] Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • [x ] Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@vhawk19 vhawk19 requested a review from yetudada as a code owner October 4, 2020 09:08
@laisbsc laisbsc requested review from limdauto and laisbsc and removed request for yetudada October 4, 2020 09:44
Copy link
Contributor

@laisbsc laisbsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vhawk19 Awesome! Thanks for this. Can you please add your name to the RELEASE.md and we will be good to go! :)

🎉

@vhawk19 vhawk19 requested a review from idanov as a code owner October 4, 2020 16:10
@vhawk19
Copy link
Contributor Author

vhawk19 commented Oct 4, 2020

@vhawk19 Awesome! Thanks for this. Can you please add your name to the RELEASE.md and we will be good to go! :)

🎉

I was unsure about adding my name to the supporting contributors. This is why I didn't add my name to the list of supporting contributors, however I have done the same now.

Also, is it okay if they are two different commits?

This was a great experience!! 😃

@deepyaman
Copy link
Member

@vhawk19 Awesome! Thanks for this. Can you please add your name to the RELEASE.md and we will be good to go! :)
🎉

I was unsure about adding my name to the supporting contributors. This is why I didn't add my name to the list of supporting contributors, however I have done the same now.

Can you move it to the section for the upcoming release, please? It will be near the top of RELEASE.md.

Also, is it okay if they are two different commits?

No matter! PRs to Kedro have all their commits squashed (i.e. converted into a single commit) to maintain clean, linear history.

This was a great experience!! 😃

@laisbsc laisbsc removed the request for review from idanov October 6, 2020 13:41
@laisbsc
Copy link
Contributor

laisbsc commented Oct 6, 2020

@vhawk19 as soon as you address the comment above, we will be ready to review and merge. :)

Thanks again for contributing!

@lorenabalan
Copy link
Contributor

@vhawk19 as soon as you address the comment above, we will be ready to review and merge. :)

Thanks again for contributing!

I've gone ahead and done that for you just so I can quickly tidy this up and merge, but for future reference: 7f74459

Thank you and hoping to see back here soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KED-2045] Update credentials example for S3 bucket specs
4 participants