Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give name of function inside incorrect parameters error #538

Closed
wants to merge 20 commits into from
Closed

give name of function inside incorrect parameters error #538

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0757658
give name of function inside incorrect parameters error
WaylonWalker Oct 3, 2020
034e7b7
update tests
WaylonWalker Oct 3, 2020
e162ca7
correct function name in tests
WaylonWalker Oct 3, 2020
d025a45
add improved error messages to release notice
WaylonWalker Oct 3, 2020
a88c533
Switch `func.__code__` to `repr(code)`
WaylonWalker Oct 6, 2020
f93f26c
test for incorrect arguments passed to a lambda
WaylonWalker Oct 6, 2020
7c207e7
remove word function, it is included in the repr
WaylonWalker Oct 6, 2020
786e0de
update tests to match updated repr in error
WaylonWalker Oct 6, 2020
ceaab21
format with black
WaylonWalker Oct 6, 2020
9ab3160
split expected strings to multiple lines
WaylonWalker Oct 6, 2020
eb98122
allow lambda for test function
WaylonWalker Oct 7, 2020
58636d9
correct expected repr of dummy_func_args
WaylonWalker Oct 7, 2020
1e56719
try adding \
WaylonWalker Oct 7, 2020
a316ef6
try a plain string
WaylonWalker Oct 7, 2020
1ef8405
Revert "correct expected repr of dummy_func_args"
WaylonWalker Oct 8, 2020
91e547d
Use same methodology as _func_name
WaylonWalker Oct 8, 2020
36634e4
Merge branch 'master' of https://github.com/waylonwalker/kedro into m…
WaylonWalker Oct 10, 2020
227113f
convert back to one line strings
WaylonWalker Oct 10, 2020
d26fb3c
create helper function _get_readable_func_name
WaylonWalker Oct 17, 2020
74cf21a
include 'function' inside error message
WaylonWalker Oct 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add improved error messages to release notice
  • Loading branch information
@WaylonWalker
WaylonWalker committed Oct 3, 2020
commit d025a4540a73aedb27788d05319732af0e57a5a4
3 changes: 2 additions & 1 deletion RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@
* Fixed `kedro install` for an Anaconda environment defined in `environment.yml`.
* Fixed backwards compatibility with templates generated with older Kedro versions <0.16.5. No longer need to update `.kedro.yml` to use `kedro lint` and `kedro jupyter notebook convert`.
* Improved documentation.
* Improved error messages for incorrect parameters passed into a node.

## Breaking changes to the API

## Thanks for supporting contributions
[Deepyaman Datta](https://github.com/deepyaman), [Bhavya Merchant](https://github.com/bnmerchant), [Lovkush Agarwal](https://github.com/Lovkush-A)
[Deepyaman Datta](https://github.com/deepyaman), [Bhavya Merchant](https://github.com/bnmerchant), [Lovkush Agarwal](https://github.com/Lovkush-A), [Waylon Walker](https://github.com/waylonwalker)

# Release 0.16.5

Expand Down