Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't configure logging in template pytest fixture #535

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Oct 2, 2020

Description

Development notes

Change should be replicated across:

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@deepyaman deepyaman requested a review from idanov as a code owner October 2, 2020 19:47
@lorenabalan
Copy link
Contributor

This type of change will sadly have to be replicated across all relevant starter repos. 🙃 Could you link them here in the PR description once they're up so we have a place where we keep track?

@lorenabalan
Copy link
Contributor

Thank you! @deepyaman I believe if you raise the related PRs you'll be set for Hacktoberfest. 😂

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorenabalan lorenabalan merged commit b70e88b into master Oct 8, 2020
@lorenabalan lorenabalan deleted the feature/do-not-config-logging branch October 8, 2020 15:27
@deepyaman
Copy link
Member Author

Above are all done. Free t-shirt, here I come!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants