Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support versioning of the underlying dataset with PartitionedDataset #521

Closed
wants to merge 62 commits into from

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Sep 20, 2020

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • Added tests to cover my changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@deepyaman deepyaman self-assigned this Sep 22, 2020
kedro/io/partitioned_data_set.py Outdated Show resolved Hide resolved
kedro/io/partitioned_data_set.py Outdated Show resolved Hide resolved
kedro/io/partitioned_data_set.py Outdated Show resolved Hide resolved
@deepyaman
Copy link
Member Author

@DmitriiDeriabinQB Changes made/test issues resolved; this PR should be good to go! :shipit: 🤞

@merelcht merelcht restored the feature/partition-versioning branch May 22, 2023 13:45
@merelcht
Copy link
Member

Re-open to be part of research.

@merelcht merelcht reopened this May 22, 2023
@deepyaman deepyaman changed the title [DO NOT MERGE YET] Support versioning of the underlying dataset Support versioning of the underlying dataset Jul 28, 2023
@deepyaman deepyaman added TD: implementation Tech Design topic on implementation of the issue Stage: Technical Design 🎨 Ticket needs to undergo technical design before implementation labels Jul 28, 2023
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs change (fixes the broken link in Prefect docs) LGTM. I cannot sign off on the others 🤷 Thanks @deepyaman 🏆 🏅 🌟

@noklam noklam changed the title Support versioning of the underlying dataset Support versioning of the underlying dataset with PartitionedDataset Aug 3, 2023
@deepyaman deepyaman changed the base branch from develop to main October 31, 2023 13:17
@deepyaman deepyaman changed the base branch from main to develop October 31, 2023 13:17
@astrojuanlu
Copy link
Member

Should we close this now that kedro-org/kedro-plugins#447 was opened?

@deepyaman
Copy link
Member Author

Should we close this now that kedro-org/kedro-plugins#447 was opened?

Doesn't matter to me; I'd set this to be closed automatically by kedro-org/kedro-plugins#447 already, anyway.

@merelcht
Copy link
Member

Closing in favour of kedro-org/kedro-plugins#447

@merelcht merelcht closed this Dec 11, 2023
@merelcht merelcht deleted the feature/partition-versioning branch January 4, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stage: Technical Design 🎨 Ticket needs to undergo technical design before implementation TD: implementation Tech Design topic on implementation of the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants