Change README.md CI badges to use GitHub actions #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
|
I think shields.io also has badges for Github Actions - https://shields.io/badges/git-hub-actions-workflow-status you can try that. |
Noticed the shields.io badges, added them in c7e0b21, and good spot for the docs! |
Signed-off-by: Ahdra Merali <[email protected]>
stichbury
reviewed
Jan 12, 2024
|
Checked on the docs build https://kedro--3501.org.readthedocs.build/en/3501/ and all looks good to me (the links work fine). Thank you! |
stichbury
approved these changes
Jan 12, 2024
added 2 commits
January 12, 2024 11:08
Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #3223
The good news: GitHub has a lot of documentation for adding and customising badges
The bad news: There isn't (yet) a way to customise the text on the badge xref. Currently using the same third party customiser that we used for the CircleCI badges.
The badges check the
all-checks.ymlGH Actions workflow for branches main and develop, respectively (GH Actions badges are workflow specific).Development notes
Link to the README with new badges
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile