Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flowchart to explains the difference of bootstrap_project and configure_project #3470

Merged
merged 9 commits into from
Jan 9, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jan 2, 2024

Description

Add docs and flowchart to explain the difference of boostrap_project and configure_project

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok Lam Chan <[email protected]>
@noklam noklam force-pushed the noklam/doc-bootstrap-project branch from 2b0e4b9 to c8eb23b Compare January 2, 2024 16:10
@noklam noklam marked this pull request as ready for review January 2, 2024 16:50
Signed-off-by: Nok Lam Chan <[email protected]>
for the underlying **`KedroContext`**; if specified, this will update (and therefore take precedence over) parameters retrieved from the project configuration

## `bootstrap_project` and `configure_project`
```{image} ../meta/images/kedro-session-creation.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for using this style of image rather than the ! []() markdown notation? Reason I ask is that it doesn't render on GitHub and I think it would help our readers to have visibility on the graphic here if possible (and you can add alt tags if you want them, so no need to use the rst image syntax -- AFAICT?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good question! I don't have a good idea, it appears to me @astrojuanlu did something to all mermaid diagram with this new style. I also found it annoying it won't render in VSCode.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block-level images aren't really needed https://myst-parser.readthedocs.io/en/latest/syntax/images_and_figures.html#block-level-images I kept them for consistency, they can be turned into inline images

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

docs/source/kedro_project_setup/session.md Outdated Show resolved Hide resolved
@noklam noklam removed the request for review from yetudada January 3, 2024 16:29
Signed-off-by: Nok Lam Chan <[email protected]>
@noklam noklam enabled auto-merge (squash) January 3, 2024 16:34
@noklam noklam requested a review from stichbury January 8, 2024 15:32
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@noklam noklam merged commit aefe378 into main Jan 9, 2024
11 checks passed
@noklam noklam deleted the noklam/doc-bootstrap-project branch January 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants