Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oversight following #3426 #3460

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Dec 21, 2023

Description

Add example_pipeline to test starter pyproject.toml. This should also resolve failing builds on kedro-airflow.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@AhdraMeraliQB AhdraMeraliQB requested review from noklam and DimedS and removed request for merelcht December 21, 2023 17:21
@AhdraMeraliQB AhdraMeraliQB marked this pull request as draft December 21, 2023 17:26
@AhdraMeraliQB AhdraMeraliQB changed the title Fix oversight following #3365 Fix oversight following #3426 Dec 21, 2023
@AhdraMeraliQB AhdraMeraliQB marked this pull request as ready for review December 21, 2023 18:29
Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AhdraMeraliQB ! LGTM

@AhdraMeraliQB AhdraMeraliQB merged commit 81ab60a into main Dec 22, 2023
30 checks passed
@AhdraMeraliQB AhdraMeraliQB deleted the fix/test_starter-pyproject branch December 22, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants