Make source_dir discoverable for non-src project #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
3 tasks
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
noklam
requested review from
yetudada,
astrojuanlu,
stichbury and
merelcht
as code owners
noklam
requested review from
SajidAlamQB and
AhdraMeraliQB
and removed request for
astrojuanlu and
yetudada
Signed-off-by: Nok Lam Chan <[email protected]>
|
Will this affect ProjectMetadata? Just thinking of the knock-on effects #3426 had when adding example-pipeline to |
|
@AhdraMeraliQB Good question! I don't think this will have an impact. Unlike the new starters/tool situation, kedro/kedro/framework/startup.py Line 104 in bdedb53 The change is merely surface the config in a project |
SajidAlamQB
approved these changes
Jan 4, 2024
AhdraMeraliQB
approved these changes
Jan 4, 2024
| @@ -31,6 +31,8 @@ Every Kedro project comes with a default pre-populated `pyproject.toml` file in | |||
| package_name = "package_name" | |||
| project_name = "project_name" | |||
| kedro_init_version = "kedro_version" | |||
| tools = "" | |||
There was a problem hiding this comment.
If we are including tools here we should probably include example_pipeline as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2962, surface the default settings in
pyproject.tomlto make is easier to discover.The original default is hidden here:
kedro/kedro/framework/startup.py
Line 104 in bdedb53
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile