Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Minor issues/improvements to pyproject.toml #3426

Merged
merged 25 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
93fded8
unique tool entires and QoL for pyproject.toml
SajidAlamQB Dec 14, 2023
39c1951
revert unique entries change
SajidAlamQB Dec 14, 2023
6abe298
Update cli.py template (#3428)
AhdraMeraliQB Dec 15, 2023
b643b23
Add logging about not using async for Sequential and Parallel runners…
merelcht Dec 15, 2023
f8c2a8e
Don't include requirements only needed for example pipeline (#3425)
SajidAlamQB Dec 18, 2023
848b4dc
Sort `requirements.txt` based on package name only (#3436)
deepyaman Dec 18, 2023
bf9cf82
Pass tools through as list
Dec 19, 2023
c96c5a0
Revert "Pass tools through as list"
Dec 19, 2023
8d16726
Remove duplicates
Dec 19, 2023
9a2d5d5
Fix for no add-ons selected
Dec 19, 2023
e587460
Merge branch 'main' into dev/tools-minor-bug-fixes
AhdraMeraliQB Dec 19, 2023
6f17b98
Merge branch 'main' into dev/tools-minor-bug-fixes
AhdraMeraliQB Dec 20, 2023
8e6f6b8
Lint
Dec 20, 2023
f31ae59
Add example as recognised key
Dec 20, 2023
36866fd
Add example as recognised key pt2
Dec 20, 2023
0021ae0
Merge branch 'main' into dev/tools-minor-bug-fixes
AhdraMeraliQB Dec 20, 2023
47ef1f2
Add example as recognised key pt3
Dec 20, 2023
9be2f4c
Merge branch 'dev/tools-minor-bug-fixes' of github.com:kedro-org/kedr…
Dec 20, 2023
6e29a8c
Add example as recognised key pt4
Dec 20, 2023
40558d4
Add example as recognised key pt5
Dec 20, 2023
4220d2a
Add example as recognised key pt6
Dec 20, 2023
3a2f1fe
Add example as recognised key pt7
Dec 20, 2023
4b78c64
Merge branch 'main' into dev/tools-minor-bug-fixes
AhdraMeraliQB Dec 20, 2023
7ccbad9
Merge branch 'main' into dev/tools-minor-bug-fixes
AhdraMeraliQB Dec 20, 2023
f0ca34f
Streamline condition
Dec 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Pass tools through as list
Signed-off-by: Ahdra Merali <[email protected]>
  • Loading branch information
Ahdra Merali committed Dec 19, 2023
commit bf9cf825ff0aa6345455dc0416a4e8ea4359324f
24 changes: 12 additions & 12 deletions kedro/framework/cli/starters.py
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,8 @@ def _get_extra_context( # noqa: PLR0913
NUMBER_TO_TOOLS_NAME[tool]
for tool in _parse_tools_input(tools) # type: ignore
]
extra_context["tools"] = str(extra_context["tools"])
else:
extra_context["tools"] = [] # type: ignore

extra_context["example_pipeline"] = (
_parse_yes_no_to_bool(
Expand Down Expand Up @@ -879,17 +880,16 @@ def _create_project(template_path: str, cookiecutter_args: dict[str, Any]):
)

# we can use starters without tools:
if tools is not None:
if tools == "[]": # TODO: This should be a list
click.secho(
"You have selected no project tools",
fg="green",
)
else:
click.secho(
f"You have selected the following project tools: {tools}",
fg="green",
)
if tools == []:
click.secho(
"You have selected no project tools",
fg="green",
)
else:
click.secho(
f"You have selected the following project tools: {tools}",
fg="green",
)

if example_pipeline is not None:
if example_pipeline:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespaces = false
package_name = "{{ cookiecutter.python_package }}"
project_name = "{{ cookiecutter.project_name }}"
kedro_init_version = "{{ cookiecutter.kedro_version }}"
tools = {{ cookiecutter.tools | default('') | string | replace('\"', '\\\"') }}
tools = {{ cookiecutter.tools | default([]) | list | replace('\"', '\\\"') }}
example_pipeline = "{{ cookiecutter.example_pipeline }}"

[tool.pytest.ini_options]
Expand Down