Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Provide scaler governance definition #65

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Aug 4, 2022

Provide scaler governance definition

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to #5

@tomkerkhove
Copy link
Member Author

Took inspiration on #18 by @jeffhollan

SCALERS.md Show resolved Hide resolved
SCALERS.md Outdated Show resolved Hide resolved
SCALERS.md Show resolved Hide resolved
SCALERS.md Show resolved Hide resolved
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the proposal, my comments are not blockers

SCALERS.md Outdated Show resolved Hide resolved
SCALERS.md Show resolved Hide resolved
@jeffhollan
Copy link
Member

Looks good - my main comment is I don't think we necessarily need to require all scalars have a maintainer - but scalars that don't need to be clearly identified and users should consume at their own risk (maintainers won't promise to fix bugs or anything else, and will be marked as 'help needed')

@tomkerkhove
Copy link
Member Author

Looks good - my main comment is I don't think we necessarily need to require all scalars have a maintainer - but scalars that don't need to be clearly identified and users should consume at their own risk (maintainers won't promise to fix bugs or anything else, and will be marked as 'help needed')

Something like "Community maintained"? What would be the stimulation for anyone to become the maintainer then? Won't that end up with all scalers be community maintained?

SCALERS.md Outdated Show resolved Hide resolved
SCALERS.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

Looks good - my main comment is I don't think we necessarily need to require all scalars have a maintainer - but scalars that don't need to be clearly identified and users should consume at their own risk (maintainers won't promise to fix bugs or anything else, and will be marked as 'help needed')

Something like "Community maintained"? What would be the stimulation for anyone to become the maintainer then? Won't that end up with all scalers be community maintained?

Agree with @jeffhollan

I doubt we are able to engage enough people to cover majority of existing scalers. What would be the result them? To drop those scalers from the next release?

@tomkerkhove
Copy link
Member Author

I'm OK with adding that, but how do we convince people to take ownership of a scaler then @zroubalik @jeffhollan?

@zroubalik
Copy link
Member

I'm OK with adding that, but how do we convince people to take ownership of a scaler then @zroubalik @jeffhollan?

SWAG and fame? 😄

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeffhollan jeffhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @tomkerkhove - this looks great

SCALERS.md Outdated Show resolved Hide resolved
@tomkerkhove tomkerkhove merged commit 3e36500 into kedacore:main Aug 25, 2022
@tomkerkhove tomkerkhove deleted the scaler-governance branch August 25, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants