You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous failing check was because of CoreImageFilter and GaussianBlur on a WatchOS target which is unavailable. I've added #if os(iOS) || os(tvOS) || os(macOS) to prevent running these tests on that target.
testDefaultImageCost() encountered an error (Test runner never began executing tests after launching. If you believe this error represents a bug, please attach the result bundle at /Users/runner/Library/Developer/Xcode/DerivedData/Nuke-bycrsvaaztorfmesymoxfuvcgnfe/Logs/Test/Test-Nuke-2022.11.20_14-31-06-+0000.xcresult)
I've just checked and tested it again, and even with randomized order ON, nothing failed. I didn't modify that test at all. Do you have any idea what's going on?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @kean 👋 I've added some new tests that will increase the code coverage from 91.3% to 92.3% .