🐛 Inject kcp-start-informers
logger into correct hook context
#3134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've observed log lines like the one below for quite a while:
Note the double entry
"postStartHook":"kcp-start-informers","postStartHook":"kcp-start-controllers"
.Turns out that in the
kcp-start-informers
post start hook the logger gets injected intoctx
. That's however not the context of the hook, it's the main context used by the whole(s *Server) Run
method! This PR creates a newhookCtx
that is explicitly instantiated within the hook and is subsequently passed to all informers and the server bootstrap code.Note this is relatively low priority and I don't want it to block #3132.
Related issue(s)
Fixes #
Release Notes