🐛 Partially revert 3105 to not run goreleaser multiple times #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
release-note-none
|
/cc @mjudeikis @sttts |
kcp-ci-bot
added
the
size/XS
embik
changed the title
|
/lgtm |
|
LGTM label has been added. Git tree hash: 1b293dfe7d8910dc08134b649513f4af3fcd06d0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #3105, we added additional triggers to the
goreleaseraction, but it seems to me that had unintended consequences, namely #3121 -- now the action runs three times, and all three of them tried to upload binaries to the release:Looks like they raced to upload artefacts, and now the checksum file (which came from one of these jobs) doesn't match all uploaded artefacts (since they came from different jobs). I'm not sure if
prerelease: autoshould be removed, so I'm only reverting the triggers since they are the root cause for this behaviour.Related issue(s)
Fixes #
Release Notes