✨ Add 'metrics-viewer' user to ClusterRoleBinding in metrics-viewer battery
#3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tery Signed-off-by: Marvin Beckers <[email protected]>
|
/lgtm |
|
LGTM label has been added. Git tree hash: 3c7b0d33e1a7d10549a219efff9cda0d7dc557bb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've been thinking about how to get metrics out of kcp for the Helm chart. The
metrics-viewerbattery is a great starting point, but requires you to extract the service account token out of kcp, which seems hard to do.This PR adds another entity to the
ClusterRoleBindingsubjects: Ametrics-vieweruser. In the Helm chart, we can create a certificate for that user entity and then pass that certificate as credentials to e.g. aServiceMonitorfor prometheus-operator. That seems to be the smoothest course of action to me.Related issue(s)
Fixes #
Release Notes