🌱 Increase resource requests on Prow jobs but only run if code changed #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dace60
to
06e2847
Compare
Signed-off-by: Marvin Beckers <[email protected]>
06e2847
to
fe94695
Compare
|
/retest |
1 similar comment
|
/retest |
|
/cc @mjudeikis @xrstf |
|
LGTM label has been added. Git tree hash: 739ddc40786e4b7a31888f220a1460d3abbb569f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR increases the memory and cpu requests on Prow jobs for e2e tests to ensure that they get their own nodes with minimal interference. At the same time, it adds
run_if_changedto ensure that we no longer run e2e tests on non-code changes.In addition, I'm reducing the number of runs in
pull-kcp-test-e2e-multiple-runsfrom 3 to 2. That should be "good enough" while reducing the runtime of the job by one third.Related issue(s)
Fixes #
Release Notes