Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add rebase documentation #2950

Merged
merged 1 commit into from
May 18, 2023

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented May 9, 2023

Summary

Add documentation on the rebase process.

Signed-off-by: Andy Goldstein <[email protected]>
@ncdc ncdc changed the title 📖 WIP Add rebase documentation 📖 Add rebase documentation May 10, 2023
@ncdc ncdc requested review from sttts and removed request for jmprusi May 10, 2023 13:58
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like all the highlights - nice write-up!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@xrstf
Copy link
Contributor

xrstf commented May 15, 2023

This is great and will be an amazing help in the future :-)

@waltforme
Copy link
Contributor

Maybe a dumb question: Why does kcp-dev/apimachinery requires k8s.io/api? Sounds like a 'reversed' dependency? Thanks!

@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented May 18, 2023

@waltforme I don't know where the kcp-dev/apimachinery name came from in the beginning, to be honest. It's not related to k8s.io/apimachinery and untangling it might be a good use of time. The contents in the repo are related like this:

Perhaps deleting the repo and subsuming the content into the more appropriate places would be good.

@ncdc ncdc closed this May 18, 2023
@ncdc ncdc reopened this May 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 7d017c7 into kcp-dev:main May 18, 2023
@waltforme
Copy link
Contributor

I see. Now the dependency makes sense. Also it explains why the repository is so small.
Maybe I should take a closer look before asking this.
Thanks for the detailed explanations! @stevekuznetsov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants