馃尡 minor docs improvements #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ncdc
commented
Mar 3, 2023
ncdc
commented
- Fix file names so they more closely match the h1 headings. This makes the leftnav sort alphabetically.
- Move the concepts index page to terminology.md. Switch the index to a section overview page.
- Add missing descriptions from a couple of the pages and fix punctuation for consistency.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Make sure file names more closely match their h1 heading at the top of each document, as mkdocs sorts the leftnav by file name, not by h1 heading. Signed-off-by: Andy Goldstein <[email protected]>
Move the terminology content from concepts/index.md to concepts/terminology.md, so it is a standalone page. Make concepts/index .md a section overview page. Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
|
/approve |
openshift-ci
bot
added
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
kcp-dev/contrib-tmc#93 |
Signed-off-by: Andy Goldstein <[email protected]>
nrb
reviewed
Mar 3, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, nrb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.