馃悰 Prevent gc/quota workqueue backlogs #2764
Conversation
Run the initial monitor syncing in a goroutine to avoid any stalling here to block a worker. Signed-off-by: Andy Goldstein <[email protected]>
|
https://github.com/kcp-dev/kubernetes/blob/f48a2e575b3bf96221060778f57689972c3709b1/pkg/controller/resourcequota/resource_quota_controller_patch.go#L80 for quota (and similarly for gc) is blocking and never ends because the |
|
@sttts interested in your thoughts |
|
/lgtm Adding a timeout on the context sounds good to me; is there really a benefit to leaving it off? |
|
Not really, upstream's is 30 seconds IIRC. I guess I thought we wouldn't have an issue since we don't have API aggregation... |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Summary
Run the initial monitor syncing in a goroutine to avoid any stalling here to block a worker.
Related issue(s)
Maybe #1878 #2665