Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix docs deploy github action #2223

Merged
merged 1 commit into from
Oct 19, 2022
Merged

📖 Fix docs deploy github action #2223

merged 1 commit into from
Oct 19, 2022

Conversation

avinal
Copy link
Member

@avinal avinal commented Oct 19, 2022 •
edited
Loading

Summary

  • Fix docs deploy github actions

Requirement

  • please create an orphan and empty gh-pages branch before merging this pr
git switch --orphan gh-pages
git commit --allow-empty -m "create empty gh-pages branch"
git push origin gh-pages
  • ensure that GitHub Actions is set as source in GitHub Pages
    image

Test deployment

https://avinal.space/kcp/main

@openshift-ci openshift-ci bot requested review from ncdc and sttts October 19, 2022 09:02
@avinal avinal changed the title Fix docs deploy github action 📖 Fix docs deploy github action Oct 19, 2022
@avinal avinal marked this pull request as draft October 19, 2022 09:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@avinal avinal marked this pull request as ready for review October 19, 2022 09:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@avinal avinal marked this pull request as draft October 19, 2022 10:19
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@avinal
Fix docs deploy github action
d267b2c 
- add required permissions
- fix wrong path to docs folder
- remove cli folder and generate _index.md at build time

Signed-off-by: Avinal Kumar <[email protected]>
@avinal avinal marked this pull request as ready for review October 19, 2022 11:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2022
@sttts
Copy link
Member

sttts commented Oct 19, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit cfcf339 into kcp-dev:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc Awaiting requested review from ncdc

@sttts sttts Awaiting requested review from sttts

@davidfestal davidfestal Awaiting requested review from davidfestal

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avinal @sttts @openshift-merge-robot