🐛 Correctly serve APIBindings in the APIExport virtual workspace #2189
Conversation
|
|
||
| t.Logf("Verifying APIExport 1 serves APIBindings 1|1, 1|2, and 2|1") | ||
| verifyBindings(workspace1, "export1", func(bindings []apisv1alpha1.APIBinding) error { | ||
| // "workspace1|binding1", "workspace2|binding1", "workspace1|binding2") |
|
Hit kcp-dev/contrib-tmc#89 flake |
|
Looking through issues, it looks like this PR fixes #1421, is that the case? |
Thanks, couldn't find it quickly |
|
Fixes: #2181 |
Switch from checking APIBinding phase for determining what actions to perform to instead always trying to resolve desired state. Fix bug in the APIExport virtual workspace that prevented it from including APIBindings for the APIExport when there wasn't a permission claim for APIBindings. Add e2e test for APIBindings with/without permission claims in the APIExport virtual workspace. Signed-off-by: Andy Goldstein <[email protected]>
94f9483
to
1f94b0b
Compare
| @@ -139,11 +139,11 @@ var ( | |||
|
|
|||
| someOtherWidgetsAPIResourceSchema = &apisv1alpha1.APIResourceSchema{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: "another.widgets.other.io", | |||
There was a problem hiding this comment.
What's the meaning of this change?
There was a problem hiding this comment.
This is meant to be the conflicting schema, and it needs to be in the same API group. The conflict test cases passed before because they were relying on the getCRD behavior defined below to return a widgets.kcp.dev CRD (the conflict checker now uses a schema instead of a CRD).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tunnel flake |
Summary
Fix bug in the APIExport virtual workspace that prevented it from including APIBindings for the APIExport when there wasn't a permission claim for APIBindings.
Switch from checking APIBinding phase for determining what actions to perform to instead always trying to resolve desired state.
Add e2e test for APIBindings with/without permission claims in the APIExport virtual workspace.
Related issue(s)
Fixes #1421
Fixes: #2181